New Feature: dfx canister install

[hansl]

Jira: DFX-429

When using the output of a dfx build on an ActorScript file, we get

An error occured:
SerdeCbor(
    ErrorImpl {
        code: EofWhileParsingValue,
        offset: 0,
    },
)

This is from the decoding of the response. I'll fix that before moving this to an official PR.

[paulyoung]

I think we should have RequestStatusResponse and QueryResponse since the statuses for request-status and query are different now (maybe they always were and I implemented this incorrectly)

[paulyoung]

We could lose the A type parameter in doing that since each *Response enum could specify the type of its reply.

[hansl]

I was wondering how far I should take this PR in refactoring the old stuff. I guess I'll have to work on this now.

[hansl]

Actually I'd like to steer away from changing the old stuff. Let's stay focused.

I created a task in JIRA to refactor the API client. https://dfinity.atlassian.net/browse/SDK-446

[paulyoung]

Since we are assigning names to canisters in the project config, can we just provide the name of the canister we want to install instead?

The about text implies that a canister will be built so I'm a bit confused why we'd need to provide a wasm file.

[hansl]

This is where the flow breaks a bit. Right now we only have a canister 42. create_canister will return a "random" ID so we might not want to store it in the JSON (since restarting the net from nothing would give non-deterministic IDs). The best location would probably be to have our own coordinator on the test net that will be a store of name to canister ID and do a query before we do every submit. That's the best I could come up with.

Do you have any ideas to improve this?

[hansl]

Let's keep the ID and wasm. I added a task for implementing the env.production.json mapping we discussed: https://dfinity.atlassian.net/browse/SDK-447

[paulyoung]

Do you have any ideas to improve this?

Based on the config file format (the last time I looked) I was thinking that something like dfx install hello would amount to looking at the canisters.hello.main field, building that, and then installing the resulting Wasm file.

[paulyoung]

I think a test called install_code_request_serialization that is equivalent to query_request_serialization would be good.

[hansl]

Added 3 tests - Serialization, Response 200, Response 400.

[hansl]

@paulyoung Please take another look.