feat: v2 of BTreeMap::Node to support unbounded types.
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the proptest for nodes more rigorous by: * Generating internal nodes that include children, and not just leaf nodes. * Generate nodes with zero-sized keys and values Enhancements to the documentation are also included.
Introduces V2 of `BTreeMap::Node`, which has a smaller memory footprint than V1 and includes support unbounded types. The implementation is currently not very efficient, as it deserializes all entries on load and serializes all entries on save. Performance enhancements will be included in subsequent PRs. Note that V2 here is only used in tests and production continues to use V1.
dsarlis
reviewed
Aug 16, 2023
# Conflicts: # src/btreemap/node.rs # src/btreemap/node/tests.rs # src/btreemap/node/v1.rs
dsarlis
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces V2 of
BTreeMap::Node, which has a smaller memory footprint than V1 and includes support for unbounded types.The implementation is currently not very efficient, as it deserializes all entries on load and serializes all entries on save. Performance enhancements will be included in subsequent PRs.
Note that V2 here is only used in tests and production continues to use V1.