Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: do not store key size in BTreeMap if size is fixed. #122

Merged
merged 48 commits into from
Sep 11, 2023
Merged

perf: do not store key size in BTreeMap if size is fixed. #122

merged 48 commits into from
Sep 11, 2023

Conversation

ielashi
Copy link
Contributor

@ielashi ielashi commented Sep 1, 2023

We don't need to store the size of the key in the node if we already know that the key is fixed in size. This results in a lower memory footprint and a slightly improved performance when using fixed types.

Here are the relevant changes in the benchmarks. Performance for v2, where this optimization is done, improves between 3% and 5%.

---------------------------------------------------

Benchmark: btreemap_insert_u64_u64
  measurements:
    instructions: 771845193 (0.14%) (change within noise threshold)
    node_load_v1: 274520203 (0.00%) (no change)
    node_save_v1: 266527196 (0.00%) (no change)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_insert_u64_u64_v2
  measurements:
    instructions: 842560173 (improved by 4.52%)
    node_load_v2: 320954654 (improved by 9.15%)
    node_save_v2: 295257753 (improved by 2.79%)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_insert_u64_blob_8
  measurements:
    instructions: 750190911 (0.15%) (change within noise threshold)
    node_load_v1: 276866073 (0.00%) (no change)
    node_save_v1: 255664450 (0.00%) (no change)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_insert_u64_blob_8_v2
  measurements:
    instructions: 806054449 (improved by 4.58%)
    node_load_v2: 320348500 (improved by 9.16%)
    node_save_v2: 272090265 (improved by 2.65%)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_insert_blob_8_u64_v2
  measurements:
    instructions: 798815035 (0.01%) (change within noise threshold)
    node_load_v2: 354784651 (-0.28%) (change within noise threshold)
    node_save_v2: 229763111 (0.00%) (no change)
    stable_memory_size: 7 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_get_u64_u64
  measurements:
    instructions: 412643077 (0.28%) (change within noise threshold)
    node_load_v1: 290922161 (0.00%) (no change)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_get_u64_u64_v2
  measurements:
    instructions: 469869216 (improved by 6.41%)
    node_load_v2: 341278594 (improved by 8.87%)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_get_u64_blob_8
  measurements:
    instructions: 409579480 (0.29%) (change within noise threshold)
    node_load_v1: 292395667 (0.00%) (no change)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_get_u64_blob_8_v2
  measurements:
    instructions: 465392548 (improved by 6.40%)
    node_load_v2: 342799065 (improved by 8.78%)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_get_blob_8_u64_v2
  measurements:
    instructions: 511860402 (0.01%) (change within noise threshold)
    node_load_v2: 373992060 (-0.30%) (change within noise threshold)
    stable_memory_size: 7 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_remove_u64_u64
  measurements:
    instructions: 1110124274 (0.12%) (change within noise threshold)
    node_load_v1: 314148033 (0.00%) (no change)
    node_save_v1: 483110284 (0.00%) (no change)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_remove_u64_u64_v2
  measurements:
    instructions: 1181708460 (improved by 3.99%)
    node_load_v2: 364710321 (improved by 9.67%)
    node_save_v2: 503803249 (improved by 2.21%)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_remove_u64_blob_8
  measurements:
    instructions: 1072866879 (0.12%) (change within noise threshold)
    node_load_v1: 313757215 (0.00%) (no change)
    node_save_v1: 457702957 (0.00%) (no change)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_remove_u64_blob_8_v2
  measurements:
    instructions: 1128519819 (improved by 3.61%)
    node_load_v2: 362925019 (improved by 9.04%)
    node_save_v2: 463945611 (-1.59%) (change within noise threshold)
    stable_memory_size: 8 (0.00%) (no change)

---------------------------------------------------

Benchmark: btreemap_remove_blob_8_u64_v2
  measurements:
    instructions: 1038966741 (0.00%) (change within noise threshold)
    node_load_v2: 397153759 (-0.30%) (change within noise threshold)
    node_save_v2: 361390361 (0.00%) (no change)
    stable_memory_size: 7 (0.00%) (no change)

@ielashi
feat: BTreeMap v2 beta
fc214cd
@ielashi
update tests
022eaa0
@ielashi
docs
12e300b
@ielashi
.
5af65b2
@ielashi
.
8620b4f
@ielashi
feat: add basic profiling to benchmarks
d45b6f5
@ielashi
.
2eb6d86
@ielashi
.
1d480f1
@ielashi
Removed unnecessary vec allocations while reading the node (~10% redu…
da72582 
…ction in instructions)

```
Benchmarking btreemap_insert_blob_4_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:10.681469 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "3_636_501_975 (78%)",
    "node_save_v2": "621_725_540 (13%)",
}

btreemap_insert_blob_4_1024_v2
                        time:   [4614.6 M Instructions 4614.6 M Instructions 4614.6 M Instructions]
                        change: [-10.016% -10.016% -10.016%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_8_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:12.381113 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "3_888_128_011 (77%)",
    "node_save_v2": "675_563_074 (13%)",
}

btreemap_insert_blob_8_1024_v2
                        time:   [5002.9 M Instructions 5002.9 M Instructions 5002.9 M Instructions]
                        change: [-10.421% -10.421% -10.421%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_16_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:14.230071 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "3_958_532_867 (77%)",
    "node_save_v2": "709_136_673 (13%)",
}

btreemap_insert_blob_16_1024_v2
                        time:   [5115.5 M Instructions 5115.5 M Instructions 5115.5 M Instructions]
                        change: [-10.015% -10.015% -10.015%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_32_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:16.079308 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_095_959_285 (77%)",
    "node_save_v2": "745_609_525 (14%)",
}

btreemap_insert_blob_32_1024_v2
                        time:   [5304.5 M Instructions 5304.5 M Instructions 5304.5 M Instructions]
                        change: [-9.8505% -9.8505% -9.8505%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_64_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:17.950616 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_528_292_556 (77%)",
    "node_save_v2": "791_326_122 (13%)",
}

btreemap_insert_blob_64_1024_v2
                        time:   [5824.6 M Instructions 5824.6 M Instructions 5824.6 M Instructions]
                        change: [-10.047% -10.047% -10.047%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_128_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:19.897701 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_965_928_945 (78%)",
    "node_save_v2": "838_234_275 (13%)",
}

btreemap_insert_blob_128_1024_v2
                        time:   [6358.7 M Instructions 6358.7 M Instructions 6358.7 M Instructions]
                        change: [-9.9985% -9.9985% -9.9985%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_256_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:21.960733 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "5_411_658_559 (77%)",
    "node_save_v2": "901_162_509 (12%)",
}

btreemap_insert_blob_256_1024_v2
                        time:   [6975.5 M Instructions 6975.5 M Instructions 6975.5 M Instructions]
                        change: [-10.178% -10.178% -10.178%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_blob_512_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:24.150752 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "6_876_355_007 (78%)",
    "node_save_v2": "1_058_462_789 (12%)",
}

btreemap_insert_blob_512_1024_v2
                        time:   [8798.0 M Instructions 8798.0 M Instructions 8798.0 M Instructions]
                        change: [-10.020% -10.020% -10.020%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_insert_u64_u64_v2: Warming up for 1.0000 ms
2023-08-23 08:46:26.530747 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "728_775_816 (58%)",
    "node_save_v2": "258_596_339 (20%)",
}

btreemap_insert_u64_u64_v2
                        time:   [1251.5 M Instructions 1251.5 M Instructions 1251.5 M Instructions]
                        change: [-0.0037% -0.0037% -0.0037%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_insert_u64_blob_8_v2: Warming up for 1.0000 ms
2023-08-23 08:46:27.652437 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "696_823_942 (58%)",
    "node_save_v2": "247_026_223 (20%)",
}

btreemap_insert_u64_blob_8_v2
                        time:   [1187.4 M Instructions 1187.4 M Instructions 1187.4 M Instructions]
                        change: [-0.0038% -0.0038% -0.0038%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_insert_blob_8_u64_v2: Warming up for 1.0000 ms
2023-08-23 08:46:28.750840 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "758_879_496 (65%)",
    "node_save_v2": "145_886_287 (12%)",
}

btreemap_insert_blob_8_u64_v2
                        time:   [1153.0 M Instructions 1153.0 M Instructions 1153.0 M Instructions]
                        change: [-0.0037% -0.0037% -0.0037%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_get_blob_4_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:29.831699 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_219_207_858 (95%)",
}

btreemap_get_blob_4_1024_v2
                        time:   [4436.9 M Instructions 4436.9 M Instructions 4436.9 M Instructions]
                        change: [-11.542% -11.542% -11.542%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_blob_8_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:32.173729 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "3_815_979_475 (94%)",
}

btreemap_get_blob_8_1024_v2
                        time:   [4044.2 M Instructions 4044.2 M Instructions 4044.2 M Instructions]
                        change: [-11.899% -11.899% -11.899%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_blob_16_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:34.595119 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "3_851_724_650 (94%)",
}

btreemap_get_blob_16_1024_v2
                        time:   [4081.1 M Instructions 4081.1 M Instructions 4081.1 M Instructions]
                        change: [-12.053% -12.053% -12.053%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_blob_32_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:37.017190 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_253_072_804 (94%)",
}

btreemap_get_blob_32_1024_v2
                        time:   [4495.5 M Instructions 4495.5 M Instructions 4495.5 M Instructions]
                        change: [-11.570% -11.570% -11.570%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_blob_64_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:39.708213 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_589_519_380 (94%)",
}

btreemap_get_blob_64_1024_v2
                        time:   [4849.5 M Instructions 4849.5 M Instructions 4849.5 M Instructions]
                        change: [-11.711% -11.711% -11.711%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_blob_128_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:42.364900 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "5_006_841_787 (94%)",
}

btreemap_get_blob_128_1024_v2
                        time:   [5272.4 M Instructions 5272.4 M Instructions 5272.4 M Instructions]
                        change: [-11.815% -11.815% -11.815%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_u64_u64_v2: Warming up for 1.0000 ms
2023-08-23 08:46:45.151204 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "768_123_966 (83%)",
}

btreemap_get_u64_u64_v2 time:   [922.10 M Instructions 922.10 M Instructions 922.10 M Instructions]
                        change: [-0.0053% -0.0053% -0.0053%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_get_u64_blob_8_v2: Warming up for 1.0000 ms
2023-08-23 08:46:46.385316 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "729_106_800 (83%)",
}

btreemap_get_u64_blob_8_v2
                        time:   [874.65 M Instructions 874.65 M Instructions 874.65 M Instructions]
                        change: [-0.0056% -0.0056% -0.0056%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_get_blob_8_u64_v2: Warming up for 1.0000 ms
2023-08-23 08:46:47.594299 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "811_967_401 (82%)",
}

btreemap_get_blob_8_u64_v2
                        time:   [987.62 M Instructions 987.62 M Instructions 987.62 M Instructions]
                        change: [-0.0049% -0.0049% -0.0049%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_get_blob_256_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:48.774213 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "5_512_886_751 (94%)",
}

btreemap_get_blob_256_1024_v2
                        time:   [5807.4 M Instructions 5807.4 M Instructions 5807.4 M Instructions]
                        change: [-12.998% -12.998% -12.998%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_get_blob_512_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:51.686246 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "6_988_975_712 (95%)",
}

btreemap_get_blob_512_1024_v2
                        time:   [7330.7 M Instructions 7330.7 M Instructions 7330.7 M Instructions]
                        change: [-12.057% -12.057% -12.057%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_blob_4_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:55.065067 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v1": "306_221_077 (29%)",
    "node_save_v1": "416_552_416 (39%)",
}

btreemap_remove_blob_4_1024_v2
                        time:   [1055.5 M Instructions 1055.5 M Instructions 1055.5 M Instructions]
                        change: [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
                        No change in performance detected.

Benchmarking btreemap_remove_blob_8_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:56.830780 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v1": "365_697_986 (27%)",
    "node_save_v1": "555_195_279 (41%)",
}

btreemap_remove_blob_8_1024_v2
                        time:   [1352.3 M Instructions 1352.3 M Instructions 1352.3 M Instructions]
                        change: [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
                        No change in performance detected.

Benchmarking btreemap_remove_blob_16_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:46:58.660166 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_691_318_570 (73%)",
    "node_save_v2": "1_237_620_989 (19%)",
}

btreemap_remove_blob_16_1024_v2
                        time:   [6415.9 M Instructions 6415.9 M Instructions 6415.9 M Instructions]
                        change: [-9.2624% -9.2624% -9.2624%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_blob_32_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:47:01.495518 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "4_889_831_082 (72%)",
    "node_save_v2": "1_311_529_745 (19%)",
}

btreemap_remove_blob_32_1024_v2
                        time:   [6715.3 M Instructions 6715.3 M Instructions 6715.3 M Instructions]
                        change: [-9.0911% -9.0911% -9.0911%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_blob_64_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:47:04.425799 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "5_090_099_125 (72%)",
    "node_save_v2": "1_381_087_495 (19%)",
}

btreemap_remove_blob_64_1024_v2
                        time:   [7031.6 M Instructions 7031.6 M Instructions 7031.6 M Instructions]
                        change: [-9.1148% -9.1148% -9.1148%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_blob_128_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:47:07.509173 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "5_468_360_953 (72%)",
    "node_save_v2": "1_467_914_004 (19%)",
}

btreemap_remove_blob_128_1024_v2
                        time:   [7553.3 M Instructions 7553.3 M Instructions 7553.3 M Instructions]
                        change: [-8.8462% -8.8462% -8.8462%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_blob_256_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:47:10.739864 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "6_380_810_655 (73%)",
    "node_save_v2": "1_601_556_578 (18%)",
}

btreemap_remove_blob_256_1024_v2
                        time:   [8714.6 M Instructions 8714.6 M Instructions 8714.6 M Instructions]
                        change: [-9.1626% -9.1626% -9.1626%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_blob_512_1024_v2: Warming up for 1.0000 ms
2023-08-23 08:47:14.235772 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "7_716_480_801 (72%)",
    "node_save_v2": "1_920_254_272 (18%)",
}

btreemap_remove_blob_512_1024_v2
                        time:   [10.603 B Instructions 10.603 B Instructions 10.603 B Instructions]
                        change: [-9.1730% -9.1730% -9.1730%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking btreemap_remove_u64_u64_v2: Warming up for 1.0000 ms
2023-08-23 08:47:18.341386 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "834_031_761 (52%)",
    "node_save_v2": "427_006_161 (27%)",
}

btreemap_remove_u64_u64_v2
                        time:   [1574.5 M Instructions 1574.5 M Instructions 1574.5 M Instructions]
                        change: [-0.0034% -0.0034% -0.0034%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_remove_u64_blob_8_v2: Warming up for 1.0000 ms
2023-08-23 08:47:19.699772 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "793_821_373 (52%)",
    "node_save_v2": "404_946_198 (27%)",
}

btreemap_remove_u64_blob_8_v2
                        time:   [1499.6 M Instructions 1499.6 M Instructions 1499.6 M Instructions]
                        change: [-0.0036% -0.0036% -0.0036%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking btreemap_remove_blob_8_u64_v2: Warming up for 1.0000 ms
2023-08-23 08:47:21.052537 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] {
    "node_load_v2": "866_070_202 (60%)",
    "node_save_v2": "258_699_270 (18%)",
}

btreemap_remove_blob_8_u64_v2
                        time:   [1427.1 M Instructions 1427.1 M Instructions 1427.1 M Instructions]
                        change: [-0.0036% -0.0036% -0.0036%] (p = 0.00 < 0.05)
                        Change within noise threshold.
```
@ielashi
update page size to match v1, add more profiling metrics
f22d30d
@ielashi
WIP: lazy loading of values
746b516
@ielashi
Load node without putting all the data into a buffer.
3d37706
@ielashi
.
789a8b5
@ielashi
.
167b9f6
@ielashi
.
eb70aac
@ielashi
.
6dcc86c
@ielashi
use segments with page idx
4e221ac
@ielashi
.
614695a
@ielashi
.
eddfaab
@ielashi
verify overflow magic
3fcce86
@ielashi
cleanup + docs
dd59a84
@ielashi
clippy
c70550e
@ielashi
fmt
68e5b70
@ielashi
fix: memory leak in V2 save
a062ffc
@ielashi
.
dc3ceed
@ielashi
.
2147806
@ielashi
clippy
dc733f8
@ielashi
perf: set page size when keys and values are bounded
a6510dc
@ielashi
feat: benchmarking script
b8173fe
@ielashi
clippy
4da6514
@ielashi ielashi requested review from roman-kashitsyn and a team as code owners September 1, 2023 13:37
dsarlis
dsarlis approved these changes Sep 5, 2023
View reviewed changes
src/storable.rs Outdated Show resolved Hide resolved
Base automatically changed from ielashi/new_benchmarking to main September 5, 2023 14:03
@ielashi ielashi enabled auto-merge (squash) September 11, 2023 07:43
@ielashi ielashi merged commit 6615f34 into main Sep 11, 2023
3 checks passed
@ielashi ielashi deleted the ielashi/fixed_key_sizes branch September 11, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsarlis dsarlis dsarlis approved these changes

@roman-kashitsyn roman-kashitsyn Awaiting requested review from roman-kashitsyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ielashi @dsarlis