Prevent running tests for drafts PR (#283)

dflex-js · Jul 13, 2021 · 5a0b0e2 · 5a0b0e2
1 parent 94f06d8
commit 5a0b0e2
Show file tree

Hide file tree

Showing 5 changed files with 816 additions and 1,035 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -72,6 +72,7 @@ jobs:
   unit-test:
     name: Unit Test
     runs-on: ubuntu-latest
+    if: github.event.pull_request.draft != true
     steps:
       - name: Check out repository
         uses: actions/checkout@master

diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml
@@ -10,6 +10,7 @@ jobs:
   cypress-dnd:
     name: E2E Test For DnD React APP
     runs-on: ubuntu-latest
+    if: github.event.pull_request.draft != true
     steps:
       - name: Check out repository
         uses: actions/checkout@master

diff --git a/packages/dnd/package.json b/packages/dnd/package.json
@@ -30,7 +30,7 @@
   "devDependencies": {
     "@cypress/code-coverage": "^3.8.1",
     "cross-env": "^7.0.2",
-    "cypress": "^7.5.0",
+    "cypress": "7.6.0",
     "eslint-plugin-cypress": "^2.11.1",
     "start-server-and-test": "^1.11.2",
     "v8-to-istanbul": "^8.0.0"

diff --git a/packages/dnd/playgrounds/dflex-react-dnd/src/extended/DnDItem.tsx b/packages/dnd/playgrounds/dflex-react-dnd/src/extended/DnDItem.tsx
@@ -29,6 +29,8 @@ export const TodoItem = ({ id, task, style, depth = 0 }: Props) => {
   }, []);
 
   const onMouseMove = (e: MouseEvent) => {
+    e.stopPropagation();
+
     if (dndEvent) {
       const { clientX, clientY } = e;
 
@@ -61,41 +63,41 @@ export const TodoItem = ({ id, task, style, depth = 0 }: Props) => {
     }
   };
 
-  const onTouchMove = (e: TouchEvent) => {
-    if (dndEvent) {
-      const { clientX, clientY } = e.touches[0];
+  // const onTouchMove = (e: TouchEvent) => {
+  //   if (dndEvent) {
+  //     const { clientX, clientY } = e.touches[0];
 
-      dndEvent.dragAt(clientX, clientY);
-    }
-  };
+  //     dndEvent.dragAt(clientX, clientY);
+  //   }
+  // };
 
-  const onTouchEnd = () => {
-    if (dndEvent) {
-      dndEvent.endDragging();
+  // const onTouchEnd = () => {
+  //   if (dndEvent) {
+  //     dndEvent.endDragging();
 
-      dndEvent = null;
+  //     dndEvent = null;
 
-      document.removeEventListener("touchend", onTouchEnd);
-      document.removeEventListener("touchmove", onTouchMove);
-    }
-  };
+  //     document.removeEventListener("touchend", onTouchEnd);
+  //     document.removeEventListener("touchmove", onTouchMove);
+  //   }
+  // };
 
-  const onTouchStart = (e: React.TouchEvent) => {
-    const { clientX, clientY } = e.touches[0];
+  // const onTouchStart = (e: React.TouchEvent) => {
+  //   const { clientX, clientY } = e.touches[0];
 
-    if (id) {
-      dndEvent = new DnD(id, { x: clientX, y: clientY });
+  //   if (id) {
+  //     dndEvent = new DnD(id, { x: clientX, y: clientY });
 
-      document.addEventListener("touchend", onTouchEnd);
-      document.addEventListener("touchmove", onTouchMove);
-    }
-  };
+  //     document.addEventListener("touchend", onTouchEnd);
+  //     document.addEventListener("touchmove", onTouchMove);
+  //   }
+  // };
 
   return (
     <li
       ref={taskRef}
       id={id}
-      onTouchStart={onTouchStart}
+      // onTouchStart={onTouchStart}
       onMouseDown={onMouseDown}
       style={style}
     >