ci: update to shared workflows #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1364--dhis2-settings.netlify.app |
ismay
force-pushed
the
update-workflows
branch
from
f918ff1
to
975a4a8
Compare
tomzemp
approved these changes
Sep 23, 2024
|
🎉 This PR is included in version 100.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhis2.atlassian.net/browse/CLI-71
Build was failing due to a dependency that was missing in d2-ui:
This dependency (loglevel) is present in the root package.json's dev dependencies, but it should be present in the regular dependencies and in the packages themselves.
Why this is only surfacing now I don't know. Might be that it was a transitive dependency that is no longer included. Anyway, I'd fix it upstream ideally, but d2-ui is such a house of cards that I'll fix it this way. We should move away from d2-ui anyway.
I've also ignored a lint error in an inline component that should just be separated out into a distinct component. As with d2-ui, pulling that thread is a separate quest.