Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HF download #103

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add support for HF download #103

merged 3 commits into from
Feb 20, 2024

Conversation

alexpalms
Copy link
Member

No description provided.

@alexpalms
Copy link
Member Author

alexpalms commented Feb 16, 2024

@discordianfish I was wondering if it could have sense to base all Docker images for the libraries on the base image so that all the common things (almost everything) are in the base one, and in the specific images we only install their additional packages.

WDYT? Could it cause problems for the matrix generation?

@discordianfish
Copy link
Member

@alexpalms Could make sense but tbh, I don't want to spend more time than necessary for now. Let's just add this to each Dockerfile

@discordianfish discordianfish merged commit 33cf9d6 into main Feb 20, 2024
78 checks passed
@discordianfish discordianfish deleted the hf-integration branch February 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants