Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore PHP 8.1 support #5

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

JanWennrich
Copy link
Contributor

We'd like to use your library in our project, but we have to support PHP 8.1 and thus can't use your library.
This PR restores PHP 8.1 compatibility.

PHP 8.1 receives security support until 31 Dec 2025: https://www.php.net/supported-versions.php

According to packagist, around 32 % of sites, that use a supported PHP version, use PHP 8.1: https://packagist.org/php-statistics

The codebase of this project is compatible with PHP 8.1, as reported by php-parallel-lint:

❯ vendor/bin/parallel-lint src/ tests/
PHP 8.1.29 | 10 parallel jobs
.....                                                        5/5 (100%)

Checked 5 files in 0.1 seconds
No syntax error found

Just PHPUnit 11 is incompatible with PHP 8.1.
Therefore I downgraded PHPUnit to version 10.
The test suite works fine with PHPUnit 10.
Furthermote PHPUnit 10 is still supported: https://phpunit.de/supported-versions.html

Copy link
Owner

@digilist digilist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yes, I think we can adjust this.

composer.json Outdated Show resolved Hide resolved
Allows this library to be installed in projects that require both versions of PHPUnit

Co-authored-by: Markus Fasselt <[email protected]>
@digilist digilist merged commit a67407e into digilist:master Aug 7, 2024
5 checks passed
@digilist
Copy link
Owner

digilist commented Aug 7, 2024

Thank you! I've tagged and released v0.4.2 with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants