Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local contract upgrade #20296

Open
wants to merge 13 commits into
base: main-2.x
Choose a base branch
from
Open

Fix local contract upgrade #20296

wants to merge 13 commits into from

Commits on Nov 13, 2024

  1. Add metadata test for local contracts, fix logic

    @paulbrauner-da
    paulbrauner-da committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5800a5e View commit details
    Browse the repository at this point in the history

  2. factorize the code

    @paulbrauner-da
    paulbrauner-da committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c95b04e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. fix tests but also uncovered a problem with interfaces

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    34b8e56 View commit details
    Browse the repository at this point in the history

  2. use toInterfaceContractId in daml-script tests

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    11820f7 View commit details
    Browse the repository at this point in the history

  3. fix typo in pretty-printer

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2c97abb View commit details
    Browse the repository at this point in the history

  4. add positive tests

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9b1b1a7 View commit details
    Browse the repository at this point in the history

  5. fix exercise by interface

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2f0637d View commit details
    Browse the repository at this point in the history

  6. always perform the upgrade validation check in the engine

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    72a8c53 View commit details
    Browse the repository at this point in the history

  7. simplify error reporting

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    62dafb0 View commit details
    Browse the repository at this point in the history

  8. ensure package is loaded before importing global contract

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b454962 View commit details
    Browse the repository at this point in the history

  9. simplify check code even more

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    25c6530 View commit details
    Browse the repository at this point in the history

  10. allow losing observers that are also signatories

    @paulbrauner-da
    paulbrauner-da committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e41c1e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Apply suggestion 

    Co-authored-by: Remy <[email protected]>
    @paulbrauner-da @remyhaemmerle-da
    paulbrauner-da and remyhaemmerle-da committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7498a33 View commit details
    Browse the repository at this point in the history