Use rb_eArgError directly.
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's part of the public API, so little point keeping another private reference to it. Additionally when storing an object in a global variable you MUST register that variable to the gc with `rb_global_variable(&cArgumentError)` and that *before* you store anything in it, so that the GC knows to update your global variable if it moves that object. In practice `ArgumentError` is pinned for now, so it would have been OK, but it might not be pinned forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's part of the public API, so little point keeping another private reference to it.
Additionally when storing an object in a global variable you MUST register that variable to the gc with
rb_global_variable(&cArgumentError)and that before you store anything in it, so that the GC knows to update your global variable if it moves that object.In practice
ArgumentErroris pinned for now, so it would have been OK, but it might not be pinned forever.