2350: Refactor settings and remove SectionList #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
ztefanie,
f1sh1918 and
LeandraH
as code owners
steffenkleinle
commented
Oct 17, 2024
| await unsubscribeNews(cityCode, languageCode) | ||
| return | ||
| } | ||
| }: CreateSettingsSectionsProps): (SettingsSectionType | null)[] => [ |
There was a problem hiding this comment.
Just removed the wrapping/section list props
steffenkleinle
force-pushed
the
2350-refactor-settings
branch
from
d6269ca
to
c52a780
Compare
steffenkleinle
force-pushed
the
2350-refactor-settings
branch
from
c52a780
to
3a72399
Compare
steffenkleinle
changed the title
LeandraH
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Refactor settings and remove SectionList.
Proposed changes
createSettingsSectionandSettingsSide effects
None.
Testing
Check that all settings still work.
Resolved issues
Fixes: #2350.