Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two optionals tags #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add two optionals tags #41

wants to merge 4 commits into from

Conversation

elrico77
Copy link

@elrico77 elrico77 commented Apr 4, 2014

  1. transaction id, this is a complement to EndToEndId
  2. FinInstnId/Othr/Id tag with NOTPROVIDED only when BIC is set to NOTPROVIDED, this way, the logic is not in the XML generator.

@ch3ric
Copy link
Contributor

ch3ric commented Apr 4, 2014

Please fix the coding style:

  • Space before/after closing parenthesis of function call prohibited
  • Expected "} else {\n"; found "}\n else {\n"

And add PHPUnit test case to make sure everything is working correctly with the new fields

Also, I think the BIC is mandatory in SEPA exports... Are you sure banks will accept files with BIC = 'NOTPROVIDED'?

@elrico77
Copy link
Author

elrico77 commented Apr 4, 2014

Hello,

the BIC is mandatory only in cross border transactions and until 31 January 2016 (exemple: http://www.betaalvereniging.nl/wp-uploads/2013/01/XML-Message-for-SDD-Version-7.0-February-2013.pdf). The tag "DbtrAgt" is a mandatory one. This version is used for SDD with french bank "Société Générale".

For the coding style and PHPUnit test, i'll fix that ASAP (monday i think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants