Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to fixed ellie in readme #2

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

harrysarson
Copy link
Contributor

The ellie linked in the readme does not compile. This commit changes it to
link to an ellie that does.

The link is currently points to https://rebrand.ly/elm-cli, I don't know if link could keep pointing there and the forwarding changed to the new ellie (which is https://ellie-app.com/83xwGryJX9ya1) instead.

The ellie linked in the readme does not compile. This commit changes it to 
link to an ellie that does.
@harrysarson
Copy link
Contributor Author

The updates to the ellie are

@@ -23,7 +23,7 @@ type alias LogOptions =

 programConfig : Program.Config CliOptions
 programConfig =
-    Program.config { version = "1.2.3" }
+    Program.config
         |> Program.add
             (OptionsParser.buildSubCommand "init" Init
                 |> OptionsParser.withDoc "initialize a git repository"

and

@@ -73,7 +73,7 @@ window.runCli = function() {
     .split(/\s+|\s*'([^']*)'|\s*"([^"]*)"/)
     .filter(element => element && element !== '')
   const args = ['', commandName, ...argsToAppend]
-  let program = Elm.Main.init({ flags: { argv: args } })
+  let program = Elm.Main.init({ flags: { argv: args, versionMessage: '1.2.3' } })
 
   program.ports.print.subscribe(message => printMessage(message, 'plain'))
   program.ports.printAndExitSuccess.subscribe(message => {

@dillonkearns
Copy link
Owner

Thank you @harrysarson!

Ellies aren't intended to stop working because they're supposed to lock in the package versions that the example was saved with. But this issue is unfortunately causing some examples to break:

ellie-app/ellie#121

But even if it weren't for that issue, it's good to have the Ellie reflect the latest API! I wish there was a nice way to save examples as part of the Github repo for the project, and then push up the changes to the Ellie examples somehow 🤔

It looks like rebrandly removed the feature that lets me update the link destination unfortunately. So I'll just merge this PR and use the direct link. Thanks so much for updating the example and submitting the PR! 🙏

@dillonkearns dillonkearns merged commit acdb995 into dillonkearns:master Feb 14, 2020
@harrysarson harrysarson deleted the patch-1 branch February 14, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants