Remove obsolete backward compatibility flag for case search dropdowns

[shubham1g5]

Technical Summary

remove backward compatibility flag introduced as part of the spec as all response to FP should have it set to true now.

Safety Assurance

Safety story

Removes a obsolete flag
tested on staging.

Automated test coverage

Updated tests in the PR to test for new behaviour

QA Plan

No QA

Special deploy instructions

• This PR can be deployed after merge with no further considerations.

Rollback instructions

• This PR can be reverted after deploy with no further considerations.

Review

• The set of people pinged as reviewers is appropriate for the level of risk of the change.

cross-request: dimagi/commcare-core#1325

[Jtang-1]

Can you remind me why we needed this flag in the first place? After the HQ changes were released and the remaining FP changes were done, HQ and Formplayer would have both working with keys right? What's the transitory period where FP still needed to support indexes?

Is it the transient period where a user is already in a form and then the "key" support changes of Formplayer gets deployed?

[shubham1g5]

Is it the transient period where a user is already in a form and then the "key" support changes of Formplayer gets deployed?

Yes the transient period was very short only to support requests in close proximity of deploy (When user is already on case search screen before and after the FP deploy).

[shubham1g5]

@Jtang-1 Flagging that this flag can be removed from Web Apps as well once this gets deployed.

[codecov]

Codecov Report

Merging #1455 (dde22ed) into master (978a051) will decrease coverage by 0.08%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1455      +/-   ##
============================================
- Coverage     69.74%   69.66%   -0.08%     
+ Complexity     1922     1918       -4     
============================================
  Files           246      246              
  Lines          7546     7543       -3     
  Branches        676      676              
============================================
- Hits           5263     5255       -8     
- Misses         2019     2022       +3     
- Partials        264      266       +2     

Files Changed	Coverage Δ
...ava/org/commcare/formplayer/objects/QueryData.java	88.23% <ø> (-0.96%)	⬇️
.../formplayer/services/MenuSessionRunnerService.java	78.41% <100.00%> (-0.61%)	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more