Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility fix for query extras #1464

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

shubham1g5
Copy link
Contributor

Technical Summary

Sentry

Jira

Corresponding FP fix for dimagi/commcare-core#1334

Safety Assurance

Retains old code for stack query extras processing which should already have been working.

Safety story

Automated test coverage

Good test coverage to check for the core worflow around stack query datums.

Migrations

  • The migrations in this code can be safely applied first independently of the code.

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1464 (737d961) into master (f92272e) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master    #1464      +/-   ##
============================================
- Coverage     69.70%   69.69%   -0.02%     
  Complexity     1920     1920              
============================================
  Files           246      246              
  Lines          7545     7549       +4     
  Branches        677      677              
============================================
+ Hits           5259     5261       +2     
- Misses         2022     2023       +1     
- Partials        264      265       +1     
Files Changed Coverage Δ
...mmcare/formplayer/services/MenuSessionFactory.java 87.34% <60.00%> (-2.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shubham1g5 shubham1g5 merged commit 79e38f5 into master Sep 14, 2023
4 of 6 checks passed
@shubham1g5 shubham1g5 deleted the queryExtrasFix branch September 14, 2023 11:49
Copy link
Contributor

@snopoke snopoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing something related to this yesterday and I was getting serialization errors from serializing the session.

I ended up doing this:

currentStep.getExtras().forEach((key, value) -> dataBuilder.put(key, (String) value));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants