add sharded WorkUnit output for non-lazy input WorkUnits in reprojection #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/kbmod/reprojection.py
jeremykubica
reviewed
Aug 8, 2024
| reprojected=True, | ||
| ) | ||
| hdul = new_work_unit.metadata_to_primary_header() | ||
| hdul.writeto(os.path.join(directory, filename)) |
There was a problem hiding this comment.
It looks like you are no longer returning a workunit down this branch. Is that correct? If so, you should update the doc string to note that the function will return None if write_output is set to True.
There was a problem hiding this comment.
Yes for now, although once I add #679 I think I'll change it to return a lazily loaded and reprojected WorkUnit. I'll change the docstring to reflect this
jeremykubica
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #678
allows us more flexibility in the reprojection workflow to choose between time and memory usage, i.e. instead of writing out an intermediary
WorkUnitbetween the ic->wu generation and reprojection we can just pass in our already loadedWorkUnitbut have the output be a shardedWorkUnit, using more memory but potentially saving time.write_outputflag inreproject_work_unitto create write the output of reprojection instead of re-materializing as aWorkUnitin memoryreproject_lazy_work_unitfunction into the mainreproject_work_unitfunction.