Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Markdown in Embeds & Content Messages #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikes
Copy link

@nikes nikes commented Jun 23, 2023

Add:

  • heading
  • list

Copy link
Member

@maddysrc maddysrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The headers look too big and the list items aren't positioned well, needs some style adjustment first.

@@ -5,7 +5,7 @@ export const createParser = (
rules: Record<string, MarkdownRule>,
transform?: (ast: SingleASTNode[]) => SingleASTNode[],
) => {
const parse = parserFor(rules, { inline: true })
const parse = parserFor(rules)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping inline here messes up a lot of assumptions that are present in how markdown rendering works and breaks a ton of other formatting in the website and this isn't the right way to go about it.

@Phyroks
Copy link

Phyroks commented Oct 21, 2023

When can we expect the merge?

@maddysrc
Copy link
Member

Not in its current state because it's broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants