Merge pull request #285 from Phoenix-Starlight/refactor/drop-dead-code #80
163 new problems found by Qodana Community for JVM
Qodana Community for JVM
163 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Unused assignment |
🔶 Warning | 60 |
Nullability and data flow problems |
🔶 Warning | 54 |
Constant values |
🔶 Warning | 13 |
Busy wait |
🔶 Warning | 12 |
Simplifiable conditional expression |
🔶 Warning | 4 |
Inner class may be 'static' |
🔶 Warning | 3 |
AutoCloseable used without 'try'-with-resources |
🔶 Warning | 2 |
Catch block may ignore exception |
🔶 Warning | 2 |
Statement with empty body |
🔶 Warning | 2 |
Instantiation of utility class |
🔶 Warning | 2 |
Loop statement that does not loop |
🔶 Warning | 2 |
Mismatched query and update of collection |
🔶 Warning | 2 |
Contract issues |
🔶 Warning | 1 |
Infinite loop statement |
🔶 Warning | 1 |
Infinite recursion |
🔶 Warning | 1 |
String concatenation in loop |
🔶 Warning | 1 |
Suspicious 'Collection.toArray()' call |
🔶 Warning | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 117 in src/main/java/com/seailz/discordjar/utils/rest/DiscordRequest.java
github-actions / Qodana Community for JVM
AutoCloseable used without 'try'-with-resources
'Response' used without 'try'-with-resources statement
Check warning on line 249 in src/main/java/com/seailz/discordjar/utils/rest/DiscordRequest.java
github-actions / Qodana Community for JVM
AutoCloseable used without 'try'-with-resources
'Response' used without 'try'-with-resources statement
Check warning on line 68 in src/main/java/com/seailz/discordjar/voice/udp/VoiceUDP.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 71 in src/main/java/com/seailz/discordjar/cache/JsonCache.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 101 in src/main/java/com/seailz/discordjar/voice/udp/VoiceUDP.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 72 in src/main/java/com/seailz/discordjar/gateway/heartbeat/HeartLogic.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 111 in src/main/java/com/seailz/discordjar/voice/ws/VoiceGatewayFactory.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 83 in src/main/java/com/seailz/discordjar/gateway/heartbeat/HeartLogic.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 36 in src/main/java/com/seailz/discordjar/utils/StatusRotor.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 38 in src/main/java/com/seailz/discordjar/utils/memory/MemoryWatcher.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 186 in src/main/java/com/seailz/discordjar/utils/rest/DiscordRequest.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 273 in src/main/java/com/seailz/discordjar/DiscordJar.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 343 in src/main/java/com/seailz/discordjar/DiscordJar.java
github-actions / Qodana Community for JVM
Busy wait
Call to `Thread.sleep()` in a loop, probably busy-waiting
Check warning on line 82 in src/main/java/com/seailz/discordjar/cache/Cache.java
github-actions / Qodana Community for JVM
Catch block may ignore exception
Empty `catch` block
Check warning on line 167 in src/main/java/com/seailz/discordjar/cache/Cache.java
github-actions / Qodana Community for JVM
Catch block may ignore exception
Empty `catch` block
Check warning on line 112 in src/main/java/com/seailz/discordjar/voice/udp/VoiceUDP.java
github-actions / Qodana Community for JVM
Constant values
Condition `packet != null` is always `true`
Check warning on line 81 in src/main/java/com/seailz/discordjar/voice/udp/VoiceUDP.java
github-actions / Qodana Community for JVM
Constant values
Condition `frame != null` is always `true` when reached
Check warning on line 48 in src/main/java/com/seailz/discordjar/model/mentions/AllowedMentions.java
github-actions / Qodana Community for JVM
Constant values
Condition `users == null` is always `false`
Check warning on line 40 in src/main/java/com/seailz/discordjar/model/mentions/AllowedMentions.java
github-actions / Qodana Community for JVM
Constant values
Condition `parse == null` is always `false`
github-actions / Qodana Community for JVM
Constant values
Condition `new Color(embed.color()) != null` is always `true`
Check warning on line 109 in src/main/java/com/seailz/discordjar/events/EventDispatcher.java
github-actions / Qodana Community for JVM
Constant values
Condition `listenersForEventType == null` is always `false`
Check warning on line 85 in src/main/java/com/seailz/discordjar/cache/Cache.java
github-actions / Qodana Community for JVM
Constant values
Condition `cache.size() == -1` is always `false`
github-actions / Qodana Community for JVM
Constant values
Result of `embed.author().url()` is always 'null'
Check warning on line 92 in src/main/java/com/seailz/discordjar/voice/udp/VoiceUDP.java
github-actions / Qodana Community for JVM
Constant values
Condition `packet != null` is always `true`