Fixes most 'abnormal' lag caused by processing subsystems. #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACCount12
approved these changes
Jan 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Reverts #2271
This has done wonders with removing most serverside lag on my local.
#4537 is still relevant. There absolutely should be fewer processing machines but at least we are now processing in linear time again. We still can't manage to process all machines in a single tick (and we likely never will) but it's faster and doesn't lag anymore.
This conflicts with #4535, but is also safer and higher priority.
I was wrong about this being the reason why SSmachines initializes slow, that has to do with atmos machines.
Details
The old implementation was pretty stupid if you know how lists are implemented.