Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attaching doors to walls #8422

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Doster-d
Copy link
Contributor

@Doster-d Doster-d commented Feb 10, 2024

Feel free to correct typos here:

About The Pull Request

Doors now connect to walls and some structures, so WE have updated the sprites.

There were a lot of sprites, and I'm not a spriter, I'm a coder, so I made an imaginary object that replaces the "generic" sprites at the doors.

P.S. I hate dreammaker sprite tools.

Credits are due to Doster-d (Coding, corrupts sprites) , GregorMN (Sprites main) and Infrared_Baron (Sprites help )

Why It's Good For The Game

It looks smooth and cool.

image

Testing

Unscrewed panel on 2x1, maint and normal doors. Opened and closed the doors. Opened and closed the doors with unscrewed panel. Locked the doors and tried to open it.

Changelog

🆑 Doster-d, GregorMN, Infrared_Baron
add: Doors now connect to walls and some structures.
imageadd: Resprited doors due to connection thnigy, now has vertical and diagonal sprites.
/:cl:

@Doster-d Doster-d changed the title Door refix to walls Attaching doors to walls Feb 10, 2024
@Doster-d
Copy link
Contributor Author

Doster-d commented Mar 3, 2024

Based on the reports received, the following bugs have been fixed:

  • Double doors did not correctly calculate filler object creations because of this "shadows" did not work correctly.
  • Some doors that should not have joined each other and walls joined, now do not.

Still investigating the next things:

  • Incorrect shadows at single doors (reported to have this in medbay IH)
  • Piss on the green doors. Not sure what the author of the bug meant.

@Doster-d
Copy link
Contributor Author

Doster-d commented Mar 3, 2024

I can't confirm the bug with incorrect shadows at single doors.

Can't find the green doors.

No bugs known to me at the moment.

Don't try to use doors that are not on the map, you will be bad.

@greggbot
Copy link
Contributor

greggbot commented Mar 15, 2024

Can't find the green doors.

Pretty sure the "green doors" are the ones in the kitchen, they did look weird with the overlay since I don't think they have proper directional sprites.

@hyperioo
Copy link
Contributor

I've heard they were some issues with Hulk's airlock doors or something. Did you get other feedback after last week?

@ValoTheValo
Copy link
Contributor

I've heard they were some issues with Hulk's airlock doors or something. Did you get other feedback after last week?

still broken. it hasn't been fixed

@Mycah142
Copy link
Contributor

I went here to try and revert this PR but it's not even merged. How is it in for a third week in a row with the same issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants