coroc: don't register type information for functions with type parameters #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #123.
This PR updates the compiler to ignore generic functions when registering type information for the runtime and its serialization layer (via
types.RegisterFuncandtypes.RegisterClosure).This expands the range of Go programs with generics that are supported. If the input program never serializes a reference to a generic function or a closure created within a generic function, the compiler output is valid. For cases where the input attempts to serialize a generic function or nested closure, a runtime check has been implemented. This check triggers a panic if type information is unavailable for the particular function.