Spawn API #174
Spawn API #174
Conversation
Signed-off-by: Chris O'Hara <[email protected]>
Signed-off-by: Chris O'Hara <[email protected]>
Signed-off-by: Chris O'Hara <[email protected]>
Signed-off-by: Chris O'Hara <[email protected]>
Signed-off-by: Chris O'Hara <[email protected]>
Signed-off-by: Chris O'Hara <[email protected]>
Signed-off-by: Chris O'Hara <[email protected]>
| @@ -156,6 +162,26 @@ func (pm *ProcessManager) Start(moduleSpec ModuleSpec, logSpec *LogSpec) (Proces | |||
| } | |||
| }() | |||
|
|
|||
| infc, err := netns.InterfaceByName("en0") | |||
There was a problem hiding this comment.
Should we avoid hard-coding the interface name here? Maybe instead we could loop over interfaces, skip the loopback, and then return the first address we find?
There was a problem hiding this comment.
I'd say let's keep it as-is for now, I think we'll revisit those soon enough that it's not a big concern 👍
|
|
||
| message SpawnResponse { | ||
| string process_id = 1; | ||
| string ip_address = 2; |
There was a problem hiding this comment.
Not sure if we want to return both the ipv4 and ipv6 address when calling spawn, or whether just the ipv4 address is fine?
There was a problem hiding this comment.
Related to my other comment, I think we'll want to have a more fleshed out description of the process configuration, including the list of network interfaces and their addresses.
This reverts commit b8addc8.
| // Addr is a unique IP address for the process. | ||
| Addr netip.Addr | ||
|
|
There was a problem hiding this comment.
This is good enough for now but I think we'll want to enhance the model later to have a representation of each network interface exposed to the process :)
| @@ -156,6 +162,26 @@ func (pm *ProcessManager) Start(moduleSpec ModuleSpec, logSpec *LogSpec) (Proces | |||
| } | |||
| }() | |||
|
|
|||
| infc, err := netns.InterfaceByName("en0") | |||
There was a problem hiding this comment.
I'd say let's keep it as-is for now, I think we'll revisit those soon enough that it's not a big concern 👍
|
|
||
| message SpawnResponse { | ||
| string process_id = 1; | ||
| string ip_address = 2; |
There was a problem hiding this comment.
Related to my other comment, I think we'll want to have a more fleshed out description of the process configuration, including the list of network interfaces and their addresses.
This partially brings back #82, giving guests the ability to spawn and kill processes.