-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openas Menu and completion for inheritance and slice roots #39
Open
Tyzeppelin
wants to merge
15
commits into
diverse-project:master
Choose a base branch
from
Tyzeppelin:openas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've just committed a new update of the metamodel. I'm not sure I didn't messed up some part of the language generation. |
name="Open As"> | ||
<commandParameter | ||
id="exactType" | ||
name="name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the name match the id?
TODO: Fix a little bug in the menu. The |
Change the reference "roots" in the slice part of the metamodel/grammar from Strings to EClass/QualifiedName.
I add custom scope providers to filters inheritable languages and sliceable parts of a model.
This contribution allows you to open your melange-generated languages with any "compatible" editor.
Adding static final String instead of plain String in code.
This might not b fully operational. I tried to fix the errors induced by the MM update. But I need (a hero) someone more skilled than me to ensure I didn't messed up everything.
After changing the metamodel, content assist over mapping rules is now available. To do so, we subclass the default proposal provider from java. The trickiest part was to find wat to change to provide the fully qualified names of our eobjects instead of just their names.
"contains() is based on equals() (reference equality), so this probably won't work. A simple name matching should do the job."
Make the classbinding more generic by extending it to all the Eclassifiers.
It's easier to give them the same id and name.
It still can't display the file properly due to problems with adapters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of my work last week.
The openas menu is "working". there is still a problem with the cast of the adapters.
The completion is working and I'll improve it to include renaming in it.