Add unpublishing action #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiky30
reviewed
Oct 23, 2019
| files_qs = files_qs.filter(versions__state=PUBLISHED) | ||
| return add_item_to_unpublish_collection(self, request, files_qs) | ||
|
|
||
|
|
||
| def get_actions(func): | ||
| def inner(self, request): | ||
| actions = func(self, request) | ||
|
|
||
| if is_moderation_enabled(): | ||
| from djangocms_moderation.admin_actions import add_items_to_collection |
There was a problem hiding this comment.
I didn't realise that we had moderation dependence in this package. Probably shouldn't have been the case.
There was a problem hiding this comment.
Well, you kind of have to have that dependence if you want to add it to a moderation collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an unpublishing action to the filer admin.
This PR depends on: django-cms/djangocms-moderation#166
Depends on #50 to run the tests.
How to test manually
Go to the folder view in filer. Click the three dots which will give you the dropdown action menu. In that menu there should be an option to select items to unpublish.
Try adding a draft file to unpublish. It will tell you that zero items were processed. Try adding a published file to unpublish it will take you to the next step to create a collection.