fix: Add more RTL improvements #526
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 33 33
Branches 3 3
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
For submit-row I think it should float to the left on rtl
| @@ -80,16 +83,22 @@ body.login.djangocms-admin-style { | |||
| } | |||
| .submit-row { | |||
| float: right; | |||
| [dir="rtl"] & { | |||
| float: right; | |||
There was a problem hiding this comment.
Yeah, obviously ... 🤦♂️
There was a problem hiding this comment.
Should this file be included?
| } | ||
| } | ||
| } | ||
|
|
||
| [dir="rtl"] .submit-row .deletelink-box, .deletelink { |
There was a problem hiding this comment.
I think .deletelink should be excluded from floating to the right:
Before:
After:
There was a problem hiding this comment.
I think the text is not floating right:
I think it should start from the right direction here:
I'm not sure if this is the right file for this issue, but the navigator isn't quite right:
For reference here's how it looks in LTR:
|
@sakhawy Thanks for the excellent feedback. I fixed most issues
The filer issues probably need to be fixed in the filer repo itself - probably both css and js. |
fsbraun
requested review from
sakhawy and
a team
and removed request for
sakhawy
There was a problem hiding this comment.
Line 49 in _icons.sass should be changed to margin-inline-end I think? You changed it back to margin-right in another PR I don't know why.
EDIT: I remember that I requested this because other icons had padding in them(?) but it looks like it backfired in the dashboard.
Also, sorry I didn't mean to notify you right away.
There was a problem hiding this comment.
I think something went wrong with select2-drop
For reference:
Notice the search icon, the remove icon, the border before the arrow, the arrow, and the width of the container.
There was a problem hiding this comment.
There should be an arrow on the left
For reference:
There was a problem hiding this comment.
The padding on lines: 134, 156, and 255.
The margin on line: 155.
There was a problem hiding this comment.
Should changes to _changelist.scss be accompanied by changes to _tables.scss?
There was a problem hiding this comment.
I think the icons for choosing permissions should be mirrored:
And the links (for choosing all and removing all) should be moved to the right. (_content.scss)
There was a problem hiding this comment.
calendarnav-previous and calendarnav-next should be swapped (?) -- they're working fine, the direction of the icons is correct, but the place is not.
There was a problem hiding this comment.
Is there a reason why padding in line 18 and margin-left in line 24 were left out?
There was a problem hiding this comment.
The padding on lines: 46 and 90
There was a problem hiding this comment.
The margin on lines 337 and 684.
The padding on lines 450 and 788.
There was a problem hiding this comment.
border-radius on lines 131 and 136
padding-left on line 201.
padding on line 329.
Description
This PR should improve admin stying further for RTL languages
@sakhawy Can you give it a manual test run?
Related resources
Checklist