Merge pull request #1085 from syucream/fix/add-fe-tests

Add some FE tests

frontend/src/components/acl/ACLHistoryList.test.tsx

@@ -2,15 +2,54 @@
  * @jest-environment jsdom
  */
 
-import { render } from "@testing-library/react";
+import { ACLHistory } from "@dmm-com/airone-apiclient-typescript-fetch";
+import { render, screen, within } from "@testing-library/react";
 import React from "react";
 
 import { ACLHistoryList } from "./ACLHistoryList";
 
 import { TestWrapper } from "TestWrapper";
 
-test("should render with essential props", () => {
-  expect(() =>
-    render(<ACLHistoryList histories={[]} />, { wrapper: TestWrapper })
-  ).not.toThrow();
+describe("ACLHistoryList", () => {
+  const histories: ACLHistory[] = [
+    {
+      user: {
+        id: 1,
+        username: "user1",
+      },
+      time: new Date("2020/01/01 00:00:00"),
+      name: "attr1",
+      changes: [
+        {
+          action: "create",
+          target: "is_public",
+          before: null,
+          after: false,
+        },
+      ],
+    },
+    {
+      user: {
+        id: 1,
+        username: "user1",
+      },
+      time: new Date("2020/01/01 00:00:00"),
+      name: "attr1",
+      changes: [
+        {
+          action: "update",
+          target: "is_public",
+          before: false,
+          after: true,
+        },
+      ],
+    },
+  ];
+
+  test("should render acl histories", () => {
+    render(<ACLHistoryList histories={histories} />, { wrapper: TestWrapper });
+
+    const bodyRowGroup = screen.getAllByRole("rowgroup")[1];
+    expect(within(bodyRowGroup).queryAllByRole("row")).toHaveLength(4);
+  });
 });

frontend/src/services/entity/Edit.test.ts

@@ -0,0 +1,72 @@
+import { findDuplicateIndexes } from "./Edit";
+
+test("findDuplicateIndexes() returns attr indexes have duplicated name", () => {
+  const actual = findDuplicateIndexes([
+    {
+      name: "unique1",
+      type: 2,
+      isMandatory: false,
+      isDeleteInChain: false,
+      isSummarized: false,
+      isWritable: false,
+      referral: [],
+      note: "note1",
+    },
+    // duplicated with index=2
+    {
+      name: "duplicated1",
+      type: 2,
+      isMandatory: false,
+      isDeleteInChain: false,
+      isSummarized: false,
+      isWritable: false,
+      referral: [],
+      note: "note2",
+    },
+    // duplicated with index=1
+    {
+      name: "duplicated1",
+      type: 2,
+      isMandatory: false,
+      isDeleteInChain: false,
+      isSummarized: false,
+      isWritable: false,
+      referral: [],
+      note: "note3",
+    },
+    {
+      name: "unique2",
+      type: 2,
+      isMandatory: false,
+      isDeleteInChain: false,
+      isSummarized: false,
+      isWritable: false,
+      referral: [],
+      note: "note4",
+    },
+    // duplicated with index=5
+    {
+      name: "duplicated2",
+      type: 2,
+      isMandatory: false,
+      isDeleteInChain: false,
+      isSummarized: false,
+      isWritable: false,
+      referral: [],
+      note: "note5",
+    },
+    // duplicated with index=4
+    {
+      name: "duplicated2",
+      type: 2,
+      isMandatory: false,
+      isDeleteInChain: false,
+      isSummarized: false,
+      isWritable: false,
+      referral: [],
+      note: "note6",
+    },
+  ]);
+
+  expect(actual).toEqual([2, 1, 5, 4]);
+});