Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine dependencies for frontend #1320

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

syucream
Copy link
Contributor

@syucream syucream commented Nov 9, 2024

Most (for now, all) of dependencies don't have concrete reasons why it must be in dependencies, not devDependencies because the frontend SPA expects to be pre-built, so I simplify the dependencies, with considering to build our own modules like #1313

Copy link
Contributor

@hinashi hinashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@userlocalhost userlocalhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for considering to make it better 👍

@userlocalhost userlocalhost merged commit b25be81 into dmm-com:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants