Enforce active turn for first warring human #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Who knows if this will have bad side-effects, but it seems to work in the lobby. Test plan: Load up my bad save game and check that India's turn is active in the lobby. It does. Hopefully we can make it through India's turn and then through every other warring players turns too. Fingers crossed on that. Also, I tried to reproduce the bad save game in a two player game. Unfortunately (?), this game seems to load fine. I can load this working save with the patch applied, and have verified that it doesn't break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who knows if this will have bad side-effects, but it seems to
work in the lobby.
Test plan:
Load up my bad save game and check that India's turn is active
in the lobby. It does. Hopefully we can make it through India's
turn and then through every other warring players turns too.
Fingers crossed on that.
Also, I tried to reproduce the bad save game in a two player
game. Unfortunately (?), this game seems to load fine. I can
load this working save with the patch applied, and have verified
that it doesn't break anything.