Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DotNetNuke.Newtonsoft.Json.dnn to reference version 13.0.3 #6174

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

dimarobert
Copy link
Contributor

@dimarobert dimarobert commented Oct 25, 2024

Fixes #6173

Summary

Updates the version of Newtonsoft.Json to reflect the actual version of the package 13.0.3.
Not sure what could be done for 13.0.2 release.

@bdukes bdukes added this to the 9.13.5 milestone Oct 25, 2024
@bdukes bdukes changed the base branch from develop to release/9.13.5 October 25, 2024 13:49
@bdukes
Copy link
Contributor

bdukes commented Oct 25, 2024

Thanks @dimarobert. I think this is also related to #5332. For all other libraries that we include, we automatically set the right version number during packaging, but Newtonsoft.Json wasn't doing that. I've pushed a few commits to this PR branch which apply that common functionality.

@bdukes bdukes requested a review from valadas October 25, 2024 17:54
@mitchelsellers mitchelsellers merged commit cecd7e6 into dnnsoftware:release/9.13.5 Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The version of Newtonsoft.Json was not updated past 13.0.1 in library package manifest.
3 participants