Rename filter/chain methods to filterer/filterer_chain for Ruby 2.6 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliebennett
force-pushed
the
rename-chain-method
branch
from
b48098e
to
7bd123b
Compare
olliebennett
force-pushed
the
rename-chain-method
branch
from
7bd123b
to
9fec998
Compare
olliebennett
changed the title
|
Hey @ajb, do you have any thoughts on this? Alternative implementation ideas? |
|
Hey @ajb - if you get a chance I'd love to get your thoughts / guidance here. 🤞 Happy to make any changes or updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #24, the inclusion of the methods
chainandfilterby this gem conflict with Ruby 2.6's new Enumerator::Chain and Enumerable#filter (see details), resulting in broken behaviour.This PR simply renames the
filtermethod tofiltererand thechainmethod tofilterer_chainin order to bypass this conflict. Obviously, this requires a change in any client code, so would need a major version bump if accepted.TODO:
filtertofiltererchaintofilterer_chainfilterer v3!