Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)fix persistent ToC, release 2.4.1 #544

Merged
merged 1 commit into from
Oct 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions properties.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
ext {
xslTNGtitle = 'DocBook xslTNG'
xslTNGbaseName = 'docbook-xslTNG'
xslTNGversion = '2.4.0'
guideVersion = '2.4.0'
xslTNGversion = '2.4.1'
guideVersion = '2.4.1'
guidePrerelease = false

docbookVersion = '5.2'
Expand Down
17 changes: 17 additions & 0 deletions src/guide/xml/changelog.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,23 @@ be of interest to users of the stylesheets. See the commits and pull requests on
<link xlink:href="https://github.com/docbook/xslTNG/">the repository</link> for
finer detail.</para>

<section xml:id="r241">
<info>
<title>Changes in version 2.4.1</title>
<productnumber>2.4.1</productnumber>
<date>2024-10-26</date>
</info>
<itemizedlist>
<listitem>
<para>A recent fix for bottom-of-page navigation links broke the persistent ToC
navigation link. This release fixes <emphasis>both</emphasis> of those problems
simultaneously;
fixed <link xlink:href="https://github.com/docbook/xslTNG/issues/543">#543</link>.
</para>
</listitem>
</itemizedlist>
</section>

<section xml:id="r240">
<info>
<title>Changes in version 2.4.0</title>
Expand Down
5 changes: 3 additions & 2 deletions src/main/scss/media-screen.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
--js-controls-header-separator-border-style: 1px solid var(--popup-annotation-border-color);
--js-controls-color: var(--surface-color);
--on-js-controls-color: var(--on-surface-color);
--z-index-on-top-of-the-world: 100;
}

html {
Expand Down Expand Up @@ -189,7 +190,7 @@ nav table td.next {

nav.bottom {
background-color: var(--nav-background-color);
z-index: 5;
z-index: var(--z-index-on-top-of-the-world);
}

nav.bottom table {
Expand All @@ -216,7 +217,7 @@ nav.top {
but it also interacts with the persistent ToC which must
go over it. If you're thinking of changing this, think
of changing js/persistent-toc.js as well. */
z-index: 100;
z-index: var(--z-index-on-top-of-the-world);
}

body.home nav.top {
Expand Down
Loading