Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly handle configuration file saving when it is a relative symlink #5282

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

correctly handle configuration file saving when it is a relative symlink #5282

wants to merge 7 commits into from
+33 −2

Commits on Jul 23, 2024

  1. fix bug with config file being a relative symlink 

    Signed-off-by: Will Wang <[email protected]>
    @willww64
    willww64 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c90705a View commit details
    Browse the repository at this point in the history

  2. Update cli/config/configfile/file.go 

    use filepath.EvalSymlink instead of check with filepath.IsAbs

Co-authored-by: Paweł Gronowski <[email protected]>
Signed-off-by: Will Wang <[email protected]>
    @willww64 @vvoland
    willww64 and vvoland committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    115fdd9 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. allow for dangling symlinks 

    Signed-off-by: Will Wang <[email protected]>
    @willww64
    willww64 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c6d1de3 View commit details
    Browse the repository at this point in the history

  2. extract path from error when NotExist error occurs 

    Signed-off-by: Will Wang <[email protected]>
    @willww64
    willww64 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    efaf3c9 View commit details
    Browse the repository at this point in the history

  3. use os.PathError to avoid an extra import 

    Signed-off-by: Will Wang <[email protected]>
    @willww64
    willww64 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    40df265 View commit details
    Browse the repository at this point in the history

  4. better to limit the scope of err 

    Signed-off-by: Will Wang <[email protected]>
    @willww64
    willww64 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a85a37e View commit details
    Browse the repository at this point in the history

  5. update comments 

    Signed-off-by: Will Wang <[email protected]>
    @willww64
    willww64 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0118291 View commit details
    Browse the repository at this point in the history