build: do not attempt to push unnamed service images #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
ndeloof
approved these changes
Jul 17, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10814 +/- ##
==========================================
+ Coverage 59.42% 59.62% +0.19%
==========================================
Files 115 115
Lines 9896 9899 +3
==========================================
+ Hits 5881 5902 +21
+ Misses 3426 3407 -19
- Partials 589 590 +1
☔ View full report in Codecov by Sentry. |
When building, if images are being pushed, ensure that only named images (i.e. services with a populated `image` field) are attempted to be pushed. Services without `image` get an auto-generated name, which will be a "Docker library" reference since they're in the format `$project-$service`, which is implicitly the same as `docker.io/library/$project-$service`. A push for that is never desirable / will always fail. The key here is that we cannot overwrite the `<svc>.image` field when doing builds, as we need to be able to check for its presence to determine whether a push makes sense. Fixes docker#10813. Signed-off-by: Milas Bowman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When building, if images are being pushed, ensure that only named images (i.e. services with a populated
imagefield) are attempted to be pushed.Services without
imageget an auto-generated name, which will be a "Docker library" reference since they're in the format$project-$service, which is implicitly the same asdocker.io/library/$project-$service. A push for that is never desirable / will always fail.The key here is that we cannot overwrite the
<svc>.imagefield when doing builds, as we need to be able to check for its presence to determine whether a push makes sense.Related issue
build --pushattempts to push images for services withoutimagedefined #10813(not mandatory) A picture of a cute animal, if possible in relation to what you did
