Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce publish (alpha) command #10815

Closed
wants to merge 1 commit into from
Closed

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jul 17, 2023

What I did
introduce publish command - this is just command skeleton, backend is missing an implementation

Related issue
this is skeleton code toward a publish command to implement compose-spec/compose-spec#288
https://docker.atlassian.net/browse/ENV-249

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Nicolas De Loof <[email protected]>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 32.25% and project coverage change: -0.21% ⚠️

Comparison is base (0be8e4a) 58.94% compared to head (12cdac7) 58.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10815      +/-   ##
==========================================
- Coverage   58.94%   58.73%   -0.21%     
==========================================
  Files         120      122       +2     
  Lines       10453    10484      +31     
==========================================
- Hits         6161     6158       -3     
- Misses       3696     3725      +29     
- Partials      596      601       +5     
Files Changed Coverage Δ
pkg/api/api.go 42.30% <ø> (ø)
pkg/compose/publish.go 0.00% <0.00%> (ø)
pkg/api/proxy.go 39.19% <33.33%> (-0.09%) ⬇️
cmd/compose/publish.go 47.05% <47.05%> (ø)
cmd/compose/alpha.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof
Copy link
Contributor Author

ndeloof commented Aug 21, 2023

Pushed to https://github.com/docker/compose/tree/publish so we can iterate on implementing this feature

@ndeloof ndeloof closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants