Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace: instrument compose up at a high-level #10831

Merged
merged 1 commit into from
Jul 19, 2023
Merged

trace: instrument compose up at a high-level #10831

merged 1 commit into from
Jul 19, 2023

Conversation

milas
Copy link
Contributor

@milas milas commented Jul 19, 2023 •
edited
Loading

What I did
Added spans around the following:

  • Image pull
  • Image build
  • Service apply
    • Scale down/up (event)
    • Recreate container (event)
    • Scale up (event)
    • Container start (event)

Related issue

JIRA: https://docker.atlassian.net/browse/ENV-233

(not mandatory) A picture of a cute animal, if possible in relation to what you did
tapir

@milas milas requested a review from a team July 19, 2023 04:08
@milas milas self-assigned this Jul 19, 2023
@milas milas requested review from nicksieger, ndeloof, StefanScherer, ulyssessouza, glours and laurazard and removed request for a team July 19, 2023 04:08
@milas milas mentioned this pull request Jul 19, 2023
Closed
@milas @glours
trace: instrument compose up at a high-level
1ae191a 
* Image pull
* Image build
* Service apply
  * Scale down/up (event)
  * Recreate container (event)
  * Scale up (event)
  * Container start (event)

Signed-off-by: Milas Bowman <[email protected]>
glours
glours approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 5159058 into docker:v2 Jul 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@nicksieger nicksieger Awaiting requested review from nicksieger nicksieger was automatically assigned from docker/compose-maintainers

@ndeloof ndeloof Awaiting requested review from ndeloof ndeloof was automatically assigned from docker/compose-maintainers

@StefanScherer StefanScherer Awaiting requested review from StefanScherer StefanScherer was automatically assigned from docker/compose-maintainers

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza ulyssessouza was automatically assigned from docker/compose-maintainers

@laurazard laurazard Awaiting requested review from laurazard laurazard was automatically assigned from docker/compose-maintainers

Assignees

@milas milas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milas @glours