Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub: autobuild refresh #21610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Dec 10, 2024

Description

Quick refresh of autobuild content.

  • Updated some linkTitles and weights to make the titles more scannable in the nav and somewhat logically ordered.
  • Updated capitalization to sentence case for consistency.
    • Automated builds->[Aa]utomated builds
    • Autobuild->[Aa]utobuild
    • Automated tests->[Aa]utomated tests
    • Autotest->[Aa]utotest
  • Updated note formatting.
  • Fixed some vale nags.
    • above->previous
    • click->select

Did a git mv with the following files, but I think the similar file names caused everything to be flagged as new/deleted rather than just renamed. Not planning to do a deeper refresh of the existing content at this time.

  • Renamed _index.md to setup.md
  • Renamed how-builds-work.md to _index.md

https://deploy-preview-21610--docsdocker.netlify.app/docker-hub/repos/manage/builds/

Related issues or tickets

ENGDOCS-2351

Reviews

  • Editorial review

@craig-osterhout craig-osterhout requested a review from a team December 10, 2024 22:05
@github-actions github-actions bot added the area/hub Issue affects Docker Hub label Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9472d0d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6763434a676d1c0008df759e
😎 Deploy Preview https://deploy-preview-21610--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback and small nits

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Autotest is still included in _vale/config/vocabularies/Docker/accept.txt (which is why vale still reports it in this PR. Since you have the case-insensitive version added, you can remove line 6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants