Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address PHP 8.4 deprecation #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dustinwilson
Copy link

PHP 8.4 introduced a change where nullable types must be explicitly defined. When running docopt in PHP 8.4 a deprecation notice is shown:

PHP Deprecated:  Docopt\SingleMatch::__construct(): Implicitly marking parameter $pattern as nullable is deprecated, the explicit nullable type must be used instead

To maintain support of PHP 5.3 I removed the type hint entirely and added an if statement to type check. If the requirement was bumped to PHP 7.1 the type hint could remain but instead be prefixed by a ?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant