Replaced ReflectionClass usages with procedural function calls

doctrine-extensions · Mar 1, 2024 · bd614cc · bd614cc
1 parent 023911f
commit bd614cc
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/src/AbstractTrackingListener.php b/src/AbstractTrackingListener.php
@@ -237,14 +237,19 @@ protected function updateField($object, $eventAdapter, $meta, $field, array $con
         }
 
         if (!empty($config['setterMethod'][$field])) {
-            $reflectionClass = $meta->getReflectionClass();
             $setterName = $config['setterMethod'][$field];
 
-            if (!$reflectionClass->hasMethod($setterName)) {
-                throw new InvalidMappingException("Setter method - [{$setterName}] does not exist in class - {$meta->getName()}");
+            if (!method_exists($object, $setterName)) {
+                throw new InvalidMappingException(
+                    sprintf(
+                        "Setter method [%s] does not exist in class %s",
+                        $setterName,
+                        $meta->getName(),
+                    ),
+                );
             }
 
-            $reflectionClass->getMethod($setterName)->invoke($object, $newValue);
+            $object->{$setterName}($newValue);
         } else {
             $property->setValue($object, $newValue);
         }

diff --git a/src/SoftDeleteable/SoftDeleteableListener.php b/src/SoftDeleteable/SoftDeleteableListener.php
@@ -104,14 +104,19 @@ public function onFlush(EventArgs $args)
                 }
 
                 if (!empty($config['setterMethod'][$config['fieldName']])) {
-                    $reflectionClass = $meta->getReflectionClass();
                     $setterName = $config['setterMethod'][$config['fieldName']];
 
-                    if (!$reflectionClass->hasMethod($setterName)) {
-                        throw new InvalidMappingException("Setter method - [{$setterName}] does not exist in class - {$meta->getName()}");
+                    if (!method_exists($object, $setterName)) {
+                        throw new InvalidMappingException(
+                            sprintf(
+                                "Setter method [%s] does not exist in class %s",
+                                $setterName,
+                                $meta->getName(),
+                            ),
+                        );
                     }
 
-                    $reflectionClass->getMethod($setterName)->invoke($object, $date);
+                    $object->{$setterName}($date);
                 } else {
                     $reflProp->setValue($object, $date);
                 }