Deprecate Yaml mapping #2396
Merged
Deprecate Yaml mapping #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2396 +/- ##
=========================================
Coverage 80.29% 80.29%
Complexity 3153 3153
=========================================
Files 159 159
Lines 8160 8160
=========================================
Hits 6552 6552
Misses 1608 1608
Continue to review full report at Codecov.
|
phansys
reviewed
Jan 1, 2022
franmomu
force-pushed
the
deprecate_yaml
branch
from
e932700
to
e2b549b
Compare
phansys
approved these changes
Jan 1, 2022
franmomu
force-pushed
the
deprecate_yaml
branch
from
e2b549b
to
396f421
Compare
|
Thanks @franmomu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORM Yaml driver was deprecated long time ago and for MongoDB it was already removed for the version we are currently supporting.
So it makes sense to deprecate Yaml mapping.
I've only added the
@deprecatedannotation to the drivers since I guess the user is already receiving deprecation warnings from the ORM, but let me know if you think we should also trigger another deprecation warning.I'll wait to #2364 get merged so we can see where no add the
@group legacyannotation in tests.