Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial DBAL 4.x support #2858

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 25, 2024

Fixes #2752

This adds support for DBAL 4.x everywhere outside the loggable extension, which isn't really feasible due to the removal of the array type and the data migration required to just change to the JSON type (follow #2502 and #2825 for more on this).

The worst B/C issues here are the removal of the Type::getName() method and the removal of the Connection::PARAM_*_ARRAY constants. The type name replacement (Type::lookupName()) only came in DBAL 3.7 and the constant replacements in DBAL 3.6, so I've bumped the DBAL minimum to use those. Most other changes are just for convenience by using the methods on the DBAL connection to handle type conversions instead of doing that stuff directly in the package code or updating the tests to add required properties for decimal fields.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (0632ab1) to head (72510d6).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
src/AbstractTrackingListener.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2858      +/-   ##
==========================================
+ Coverage   78.75%   78.82%   +0.07%     
==========================================
  Files         163      167       +4     
  Lines        8593     8637      +44     
==========================================
+ Hits         6767     6808      +41     
- Misses       1826     1829       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryuk
Copy link

Any plans to be merged soon? Thanks

@phansys phansys merged commit 755c0a7 into doctrine-extensions:main Oct 6, 2024
22 checks passed
@phansys
Copy link
Collaborator

phansys commented Oct 6, 2024

Thank you @mbabker!

@phansys
Copy link
Collaborator

phansys commented Oct 6, 2024

Any plans to be merged soon? Thanks

Sorry for the delay. 3.17.0 was released, including this PR.

@mbabker mbabker deleted the dbal-4-compat branch October 7, 2024 02:12
@Nyholm
Copy link

Nyholm commented Oct 7, 2024

Wohoo. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestampable (and maybe more extensions) don't work with DBAL 4.0.0-RC2
4 participants