Prepare PHP 8.4 support: Prevent property hooks from being used #11628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n external non-raw values without explicit code.
greg0ire
approved these changes
Oct 8, 2024
mpdude
approved these changes
Oct 8, 2024
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Stop recommending vendor-prefixed PHPDoc (doctrine#11640) Let PHPStan detect deprecated usages (doctrine#11639) Add upgrade note about property hooks (doctrine#11636) Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628) Use E_ALL instead of E_ALL | E_STRICT Add CI job for PHP 8.4 fix generating duplicate method stubs
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Stop recommending vendor-prefixed PHPDoc (doctrine#11640) Let PHPStan detect deprecated usages (doctrine#11639) Add upgrade note about property hooks (doctrine#11636) Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628) Use E_ALL instead of E_ALL | E_STRICT Add CI job for PHP 8.4 fix generating duplicate method stubs
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 2.20.x: Stop recommending vendor-prefixed PHPDoc (doctrine#11640) Let PHPStan detect deprecated usages (doctrine#11639) Add upgrade note about property hooks (doctrine#11636) Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628) Use E_ALL instead of E_ALL | E_STRICT Add CI job for PHP 8.4 fix generating duplicate method stubs
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 9, 2024
* 3.3.x: Stop recommending vendor-prefixed PHPDoc (doctrine#11640) Let PHPStan detect deprecated usages (doctrine#11639) PHPStan 1.12.6 (doctrine#11635) Add upgrade note about property hooks (doctrine#11636) Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628) Use E_ALL instead of E_ALL | E_STRICT Add CI job for PHP 8.4 fix generating duplicate method stubs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property hooks must be explicitly supported by new code, due to them having to use setRawValue/getRawValue to access the right representation for storing in the database.
For now we prevent property hooks from being used at all so that users will not run into potential BC breaks once property hooks support ships.
Related: