Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gem Wallet #294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gemcoder21
Copy link

Screenshots:

@qlpqlp
Copy link
Contributor

qlpqlp commented Nov 7, 2023

I tested the wallet on my Android 11 device

  • App closes wen trying to enable/disable a coin or token

  • Can send out 1 Doge, it gives an error.

Screenshot_20231107_185921_Gem.jpg

Screenshot_20231107_185730_Gem.jpg

Screenshot_20231107_185906_Gem.jpg

@gemcoder21
Copy link
Author

@qlpqlp thanks for providing a feedback, let me take look into it, will revert back once fixed.

@qlpqlp
Copy link
Contributor

qlpqlp commented Nov 7, 2023

Much thanks 🙂❤️

@qlpqlp
Copy link
Contributor

qlpqlp commented Nov 10, 2023

@qlpqlp thanks for providing a feedback, let me take look into it, will revert back once fixed.

Hello, I saw the new update and tested, it can send now the 1 Doge, but, if for example I want to pay 1 Doge and only have 1 Doge on the wallet, it does not send 1 Doge but only 0.99808 Doge

So, wen paying for example on our MarketPlace https://ShibeShip.com, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow:

image

My suggestion:

wen a user wants to send all amount on the wallet, in my case 1 Doge, show a warning that it will not sent all the amount and actually change the display to the "Full Amount" minus "Network Fees" or a user will not be able to pay in a full an invoice, in our case we are using https://gigawallet.dogecoin.org to create the Dogecoin invoices on https://ShibeShip.com

@gemcoder21
Copy link
Author

So, wen paying for example on our MarketPlace https://shibeship.com/, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow:

Yes, I agree that for BIP21 amount has to be what passed. We will integrate BIP21 within the next couple of weeks for btc/ltc/doge and this would work as you expected (it has to be strict rules on the protocol level).

Also, I appreciate that you have tested the app and provided feedback.

Let me know if there is anything else we should improve.

@qlpqlp
Copy link
Contributor

qlpqlp commented Nov 11, 2023

So, wen paying for example on our MarketPlace https://shibeship.com/, besides it cant pay the 1 Doge it also cant read the QR code BIP21 (https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki) to make the payment like the example bellow:

Yes, I agree that for BIP21 amount has to be what passed. We will integrate BIP21 within the next couple of weeks for btc/ltc/doge and this would work as you expected (it has to be strict rules on the protocol level).

Also, I appreciate that you have tested the app and provided feedback.

Let me know if there is anything else we should improve.

Much thanks for all your efforts :)
Great work so far on the wallet, really simple and easy to use :)

@gemcoder21
Copy link
Author

@qlpqlp according to BIP21 there is only bitcoin: prefix, where do I find list of all possible BIP21 prefixes for different blockchains? Is there a list of chains similar to BIP44?

I will start with parsing bitcoin, litecoin, dogecoin, what else if there?

@qlpqlp
Copy link
Contributor

qlpqlp commented Nov 25, 2023

@qlpqlp according to BIP21 there is only bitcoin: prefix, where do I find list of all possible BIP21 prefixes for different blockchains? Is there a list of chains similar to BIP44?

I will start with parsing bitcoin, litecoin, dogecoin, what else if there?

I only know one singular universal decentralized currency, Dogecoin :P

Probably all Layer 1 cryptocurrencies (AKA Coins, not Tokens), supports BIP21 :)

@gemcoder21
Copy link
Author

@qlpqlp according to BIP21 there is only bitcoin: prefix, where do I find list of all possible BIP21 prefixes for different blockchains? Is there a list of chains similar to BIP44?
I will start with parsing bitcoin, litecoin, dogecoin, what else if there?

I only know one singular universal decentralized currency, Dogecoin :P

Probably all Layer 1 cryptocurrencies (AKA Coins, not Tokens), supports BIP21 :)

Can you review submission again? Both iOS and Android apps should be able to support BIP21 properly and handle your example above.

Also, this this comment we have open sourced Gem Wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants