Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(katana): support raw chain id #2276

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Aug 8, 2024

Description

This PR is made in other to provide a failing example for issue #1595.

Commit on blockifier which implemented the feature: dojoengine/sequencer@07f473f

Related issue

#1595

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Summary by CodeRabbit

  • New Features

    • Introduced a new feature cairo-vm-test-utils for enhanced testing capabilities.
    • Added a new contract GetChainId to retrieve the chain ID within the StarkNet environment.
    • New test module for validating chain ID functionality.
  • Bug Fixes

    • Updated dependency versions for improved stability and performance.
  • Documentation

    • Added documentation for the read_compiled_class_artifact function to clarify its purpose.
  • Chores

    • Introduced new test data files for testing the GetChainId contract.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (f1c5214) to head (df8464f).

Files Patch % Lines
...na/executor/src/implementation/blockifier/utils.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
- Coverage   70.29%   70.27%   -0.02%     
==========================================
  Files         342      342              
  Lines       45094    45108      +14     
==========================================
+ Hits        31698    31699       +1     
- Misses      13396    13409      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm marked this pull request as draft August 8, 2024 19:29
@Eikix
Copy link
Contributor

Eikix commented Oct 22, 2024

What is the status of this @glihm @greged93?

@kariy
Copy link
Member

kariy commented Oct 23, 2024

@Eikix im workin on this rn, i've identified why it still failing, just gonna add some more test now

@Eikix
Copy link
Contributor

Eikix commented Oct 23, 2024

@Eikix im workin on this rn, i've identified why it still failing, just gonna add some more test now

<3333 okk thx

@kariy kariy changed the title test: add failing test on chain id conversion feat(katana): support raw chain id Oct 23, 2024
@kariy kariy marked this pull request as ready for review October 23, 2024 15:16
@kariy
Copy link
Member

kariy commented Oct 23, 2024

@Eikix @greged93 ok this time it should definitely work as expected

coderabbitai[bot]

This comment was marked as spam.

@kariy
Copy link
Member

kariy commented Oct 23, 2024

@Eikix @greged93 i took the liberty to rebase it to v1.0.0-alpha.16 to ease the independent testing because there are some breaking changes in the genesis json file format after the alpha.16.

@kariy kariy marked this pull request as draft October 23, 2024 15:31
coderabbitai[bot]

This comment was marked as resolved.

@dojoengine dojoengine deleted a comment from coderabbitai bot Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants