Remove Channel dependency on CHECK_ON_THREAD()

Makes progress on #13.
domfarolino · Sep 19, 2023 · 3442f53 · 3442f53
1 parent b22daf0
commit 3442f53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/mage/core/channel.cc b/mage/core/channel.cc
@@ -8,7 +8,6 @@
 
 #include "base/check.h"
 #include "base/scheduling/scheduling_handles.h"
-#include "base/threading/thread_checker.h"  // for CHECK_ON_THREAD().
 #include "mage/core/endpoint.h"
 
 namespace mage {
@@ -131,7 +130,6 @@ void Channel::SendMessage(Message message) {
 
 void Channel::OnCanReadFromSocket() {
   LOG("\n\nChannel::OnCanReadFromSocket() getpid: %d", getpid());
-  CHECK_ON_THREAD(base::ThreadType::IO);
   std::vector<char> full_message_buffer;
 
   // Read the message header.

diff --git a/mage/core/channel.h b/mage/core/channel.h
@@ -68,6 +68,10 @@ class Channel : public base::TaskLoopForIO::SocketReader {
   void SendMessage(Message message);
 
   // base::TaskLoopForIO::SocketReader implementation:
+  //
+  // See `Start()` documentation above. This method can be called immediately
+  // after `Start()` on whatever thread the Mage embedder deems is its "IO"
+  // thread.
   void OnCanReadFromSocket() override;
 
  private: