proposal for filesystem interface, sample implementation for record.go #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the start of the rolling PR for #121.
in
timetrace.go
I have defined three interfaces to interact with the filesystem.ProjectFS
,RecordFS
andReportFS
. The code will compile but not work since the dependency injection is not yet done for the interfaces. Inrecord.go
I have changed all current interactions with thefs
or theos/ioutil
lib with the newrecordFS
interface.I'd be happy for feedback on the interfaces and possible unclearness regarding decoupling the fs into multiple interfaces.