-
Notifications
You must be signed in to change notification settings - Fork 526
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Mono.Android] Add
PackageInfoFlagsLong (#8182)
Fixes: #7729 We do not currently enumify [`PackageManager.PackageInfoFlags.of(long)`][0] because it is a `long` and our tooling is built around enumifying `int` values. However, it seems to be a frequently used API, so we should try to make it nicer. Create a new `PackageInfoFlagsLong` enum which has `long` as the underlying type, which can be used as a parameter to a new `PackageManager.PackageInfoFlags.Of(PackageInfoFlagsLong)` overload: var flags = PackageManager.PackageInfoFlags.Of( PackageInfoFlagsLong.GetActivities | PackageInfoFlagsLong.GetSignatures ); // vs previous var old_flags = PackageManager.PackageInfoFlags.Of( (long)(PackageInfoFlags.Activities | PackageInfoFlags.Signatures) ); Note that the enumeration member naming convention changed, e.g. from `PackageInfoFlags.Activities` to `PackageInfoFlagsLong.GetActivities`. This was done because the verbs used by `PackageInfoFlags` members were not consistent; some members had an "implicit `Get`" e.g. `PackageInfoFlags.Activities` (which came from `PackageManager.GET_ACTIVITIES`), while others had an "explicit" verb, e.g. `PackageInfoFlags.MatchUninstalledPackages` (which came from `PackageManager.MATCH_UNINSTALLED_PACKAGES`). The new `PackageInfoFlagsLong` convention is to consistently require the verb. [0]: https://developer.android.com/reference/android/content/pm/PackageManager.PackageInfoFlags#of(long)
- Loading branch information
Showing
3 changed files
with
117 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| namespace Android.Content.PM; | ||
|
|
||
| #if ANDROID_34 | ||
| public abstract partial class PackageManager | ||
| { | ||
| public sealed partial class PackageInfoFlags | ||
| { | ||
| // Create overloads that accept PackageInfoFlagsLong | ||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android33.0")] | ||
| public static Android.Content.PM.PackageManager.PackageInfoFlags Of (PackageInfoFlagsLong value) | ||
| => Of ((long) value); | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android33.0")] | ||
| public PackageInfoFlagsLong ValueAsFlags | ||
| => (PackageInfoFlagsLong) Value; | ||
| } | ||
| } | ||
|
|
||
| // Manually created "long" version of "PackageInfoFlags" enum, created from documentation: | ||
| // https://developer.android.com/reference/android/content/pm/PackageManager.PackageInfoFlags#of(long) | ||
| [System.Flags] | ||
| public enum PackageInfoFlagsLong : long | ||
| { | ||
| None = 0, | ||
|
|
||
| GetActivities = PackageInfoFlags.Activities, | ||
|
|
||
| GetReceivers = PackageInfoFlags.Receivers, | ||
|
|
||
| GetServices = PackageInfoFlags.Services, | ||
|
|
||
| GetProviders = PackageInfoFlags.Providers, | ||
|
|
||
| GetInstrumentation = PackageInfoFlags.Instrumentation, | ||
|
|
||
| [global::System.Runtime.Versioning.ObsoletedOSPlatformAttribute ("android31.0", "The platform does not support getting IntentFilters for the package.")] | ||
| GetIntentFilters = PackageInfoFlags.IntentFilters, | ||
|
|
||
| [global::System.Runtime.Versioning.ObsoletedOSPlatformAttribute ("android28.0", "Use GetSigningCertificates instead.")] | ||
| GetSignatures = PackageInfoFlags.Signatures, | ||
|
|
||
| GetMetaData = PackageInfoFlags.MetaData, | ||
|
|
||
| GetGids = PackageInfoFlags.Gids, | ||
|
|
||
| [global::System.Runtime.Versioning.ObsoletedOSPlatformAttribute ("android24.0", "Replaced with MatchDisabledComponents.")] | ||
| GetDisabledComponents = PackageInfoFlags.DisabledComponents, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android24.0")] | ||
| MatchDisabledComponents = PackageInfoFlags.MatchDisabledComponents, | ||
|
|
||
| GetSharedLibraryFiles = PackageInfoFlags.SharedLibraryFiles, | ||
|
|
||
| GetUriPermissionPatterns = PackageInfoFlags.UriPermissionPatterns, | ||
|
|
||
| GetPermissions = PackageInfoFlags.Permissions, | ||
|
|
||
| [global::System.Runtime.Versioning.ObsoletedOSPlatformAttribute ("android24.0", "Replaced with MatchUninstalledPackages.")] | ||
| GetUninstalledPackages = PackageInfoFlags.UninstalledPackages, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android24.0")] | ||
| MatchUninstalledPackages = PackageInfoFlags.MatchUninstalledPackages, | ||
|
|
||
| GetConfigurations = PackageInfoFlags.Configurations, | ||
|
|
||
| [global::System.Runtime.Versioning.ObsoletedOSPlatformAttribute ("android24.0", "Replaced with MatchDisabledUntilUsedComponents.")] | ||
| GetDisabledUntilUsedComponents = PackageInfoFlags.DisabledUntilUsedComponents, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android24.0")] | ||
| MatchDisabledUntilUsedComponents = PackageInfoFlags.MatchDisabledUntilUsedComponents, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android24.0")] | ||
| MatchSystemOnly = PackageInfoFlags.MatchSystemOnly, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android28.0")] | ||
| GetSigningCertificates = PackageInfoFlags.SigningCertificates, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android29.0")] | ||
| MatchApex = 1073741824, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android31.0")] | ||
| [global::System.Runtime.Versioning.ObsoletedOSPlatformAttribute ("android34.0", "Use GetAttributionsLong to avoid unintended sign extension.")] | ||
| GetAttributions = PackageInfoFlags.Attributions, | ||
|
|
||
| [global::System.Runtime.Versioning.SupportedOSPlatformAttribute ("android34.0")] | ||
| GetAttributionsLong = 2147483648, | ||
| } | ||
| #endif // ANDROID_34 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters