Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/2.1] Suppress the GrayListedLeaf error code on macOS X509Chain #42876

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

bartonjs
Copy link
Member

This is a port of dotnet/runtime#32895.

Description

Recent change to macOS has caused a new error code to appear during X509Chain building. Since this error code has been identified as not having impact on the .NET X509Chain class, ignore it.

Customer Impact

Without this fix, customers who upgrade their macOS version and build X509Chains against certificates/certificate-authorities which result in the GrayListedLeaf code will get a CryptographicException due to the unmapped error.

Regression?

No, reaction to OS update.

Packaging reviewed?

Required shim library, no packaging impact.

Risk

Low, covered by unit tests (which originally discovered the issue).

@bartonjs bartonjs added area-System.Security Servicing-consider Issue for next servicing release review labels Feb 27, 2020
@bartonjs bartonjs added this to the 2.1.x milestone Feb 27, 2020
@bartonjs bartonjs requested a review from stephentoub February 27, 2020 19:03
@stephentoub
Copy link
Member

If memory serves, we've now had several of these servicing needs due to new error codes popping up. Should we revisit the decision to opt-in new codes on demand?

@bartonjs
Copy link
Member Author

Should we revisit the decision to opt-in new codes on demand?

My gut says we have to maintain a defensive posture here. But I opened dotnet/runtime#32941 to track the notion (with a hopeful "maybe there's functionality added to the OS between our old minimum and our new minimum version").

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 3, 2020
@leecow leecow modified the milestones: 2.1.x, 2.1.18 Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants