Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for nullability and null states #1192

Open
wants to merge 7 commits into
base: draft-v8
Choose a base branch
from
Open

Add examples for nullability and null states #1192

wants to merge 7 commits into from
+94 −1

Conversation

BillWagner
Copy link
Member

Fixes #1094

In the section on nullability and null states, add examples to the notes and text to illustrate possible null analysis results.

jskeet
jskeet reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supportive of the general approach, just a few suggestions.

standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
jskeet
jskeet reviewed Oct 25, 2024
View reviewed changes
standard/types.md Outdated Show resolved Hide resolved
@BillWagner BillWagner marked this pull request as ready for review October 25, 2024 15:35
@BillWagner BillWagner added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Oct 25, 2024
jskeet
jskeet approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One aspect that we should probably discuss in the meeting.

standard/types.md Outdated Show resolved Hide resolved
BillWagner
BillWagner commented Oct 28, 2024
View reviewed changes
standard/types.md Outdated Show resolved Hide resolved
@BillWagner BillWagner closed this Oct 30, 2024
@BillWagner BillWagner reopened this Oct 30, 2024
@BillWagner BillWagner closed this Nov 8, 2024
@BillWagner BillWagner reopened this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Nullable Reference Types] Provide informative notes and examples on diagnostics
2 participants
@BillWagner @jskeet