Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Syntax of the GC Pipeline Yaml #4489

Merged
merged 21 commits into from
Oct 1, 2024
Merged

Conversation

mrsharm
Copy link
Member

@mrsharm mrsharm commented Sep 27, 2024

  • Fixing Syntax of the GC Pipeline Yaml.
  • Temporarily disable long running examples to get the pipeline running.
  • Excluding running the performance pipeline in case no changes are made in the GC Infra.

@LoopedBard3 LoopedBard3 mentioned this pull request Sep 27, 2024
@LoopedBard3
Copy link
Member

LoopedBard3 commented Sep 27, 2024

@mrsharm it would probably be worth adding the gc-azure-pipelines.yml file to the normal azure-pipelines.yml exclude list, and maybe adding it to the include list of the gc-azure-pipelines.yml file (I am not sure if a yml considers itself as always in the include list or not 🤷‍♂️). This would minimize the noise from the performance scenario runs unrelated to GC in the GC commits.

@mrsharm
Copy link
Member Author

mrsharm commented Sep 30, 2024

/azp run performance-gc-ci

Copy link

No pipelines are associated with this pull request.

@mrsharm
Copy link
Member Author

mrsharm commented Sep 30, 2024

/azp run performance-gc-ci

Copy link

No pipelines are associated with this pull request.

@mrsharm
Copy link
Member Author

mrsharm commented Sep 30, 2024

/azp run performance-gc-ci

Copy link

No pipelines are associated with this pull request.

@mrsharm
Copy link
Member Author

mrsharm commented Sep 30, 2024

/azp run performance-gc-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mrsharm mrsharm requested a review from cshung September 30, 2024 19:27
LoopedBard3
LoopedBard3 previously approved these changes Sep 30, 2024
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Looks good overall as well.

azure-pipelines.yml Show resolved Hide resolved
LoopedBard3
LoopedBard3 previously approved these changes Sep 30, 2024
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍.

@mrsharm
Copy link
Member Author

mrsharm commented Sep 30, 2024

Thanks for all the help, @LoopedBard3 and @DrewScoggins! This PR has got us to test a large part of the notebook functionality and I observe that the tests are all green from the pipeline:

image

And successfully running the tests: https://dev.azure.com/dnceng-public/public/_build/results?buildId=822709&view=logs&j=6f2f97bc-132f-5f9d-ae17-411e38c19357

image

Will follow up with re-enabling the example notebook tests as these are timing out on the lab machines even though successfully running locally.

@mrsharm mrsharm enabled auto-merge (squash) September 30, 2024 19:47
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 merged commit 7c3ed5d into dotnet:main Oct 1, 2024
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants