Remove reflection from AppHostUpdateTests (#73988)

* Remove reflection from AppHostUpdateTests * Address CR feedback * Make template binary readonly for macOS
dotnet · Aug 17, 2022 · 3494c39 · 3494c39
1 parent eca5b44
commit 3494c39
Showing 1 changed file with 24 additions and 90 deletions.
diff --git a/...Microsoft.NET.HostModel.Tests/Microsoft.NET.HostModel.AppHost.Tests/AppHostUpdateTests.cs b/...Microsoft.NET.HostModel.Tests/Microsoft.NET.HostModel.AppHost.Tests/AppHostUpdateTests.cs
@@ -4,9 +4,7 @@
 using System;
 using System.IO;
 using System.Linq;
-using System.Reflection;
 using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
 using System.Text;
 using FluentAssertions;
 using Xunit;
@@ -170,36 +168,30 @@ public void ItFailsToSetGUISubsystemWithWrongDefault()
         [PlatformSpecific(TestPlatforms.AnyUnix)]
         public void ItGeneratesExecutableImage()
         {
-            using (TestDirectory testDirectory = TestDirectory.Create())
-            {
-                string sourceAppHostMock = PrepareAppHostMockFile(testDirectory);
-                string destinationFilePath = Path.Combine(testDirectory.Path, "DestinationAppHost.exe.mock");
-                string appBinaryFilePath = "Test/App/Binary/Path.dll";
-
-                chmod(sourceAppHostMock, Convert.ToInt32("755", 8)) // match installed permissions: -rwxr-xr-x
-                    .Should()
-                    .NotBe(-1);
-
-                GetLastError()
-                    .Should()
-                    .NotBe(4); // EINTR
-
-                GetFilePermissionValue(sourceAppHostMock)
-                    .Should()
-                    .Be(Convert.ToInt32("755", 8));
-
-                HostWriter.CreateAppHost(
-                    sourceAppHostMock,
-                    destinationFilePath,
-                    appBinaryFilePath,
-                    windowsGraphicalUserInterface: true);
-
-                GetFilePermissionValue(destinationFilePath)
-                    .Should()
-                    .Be(Convert.ToInt32("755", 8));
-            }
-
-            int GetLastError() => Marshal.GetLastWin32Error();
+            using TestDirectory testDirectory = TestDirectory.Create();
+            string sourceAppHostMock = PrepareAppHostMockFile(testDirectory);
+            string destinationFilePath = Path.Combine(testDirectory.Path, "DestinationAppHost.exe.mock");
+            string appBinaryFilePath = "Test/App/Binary/Path.dll";
+
+            // strip executable permissions from this AppHost template binary
+            File.SetUnixFileMode(sourceAppHostMock, UnixFileMode.UserRead | UnixFileMode.GroupRead | UnixFileMode.OtherRead);
+
+            // -rwxr-xr-x
+            const UnixFileMode expectedPermissions = UnixFileMode.UserRead | UnixFileMode.UserExecute | UnixFileMode.UserWrite |
+                UnixFileMode.GroupRead | UnixFileMode.GroupExecute |
+                UnixFileMode.OtherRead | UnixFileMode.OtherExecute;
+
+            HostWriter.CreateAppHost(
+                sourceAppHostMock,
+                destinationFilePath,
+                appBinaryFilePath,
+                windowsGraphicalUserInterface: true);
+
+            // assert that the generated app has executable permissions
+            // despite different permissions on the template binary.
+            File.GetUnixFileMode(destinationFilePath)
+                .Should()
+                .Be(expectedPermissions);
         }
 
         [Fact]
@@ -370,64 +362,6 @@ private string PrepareAppHostMockFile(TestDirectory testDirectory, Action<byte[]
             0, 112, 2, 0, 0, 4, 0, 0, 0, 0, 0, 0, 3, 0, 96, 193, 0, 0, 24,
             0, 0, 0, 0, 0, 0, 16, 0, 0, 0, 0 };
 
-        [DllImport("libc", SetLastError = true)]
-        private static extern int chmod(string pathname, int mode);
-
-        private static int GetFilePermissionValue(string path)
-        {
-            int modeValue = FileStatusProvider.GetFileMode(path);
-
-            // st_mode is typically a 16-bits value, high 4 bits are filetype and low 12
-            // bits are permission. we will clear first 20 bits (a byte and a nibble) with
-            // the following mask:
-            modeValue &= 0x1ff;
-
-            modeValue
-                .Should()
-                .BeInRange(0, 511);
-
-            return modeValue;
-        }
-
-        private static class FileStatusProvider
-        {
-            private static FieldInfo s_fileSystem_fileStatusField, s_fileStatus_fileCacheField, s_fileStatusModeField;
-
-            static FileStatusProvider()
-            {
-                if (!OperatingSystem.IsWindows())
-                {
-                    try
-                    {
-                        s_fileSystem_fileStatusField = typeof(FileSystemInfo).GetField("_fileStatus", BindingFlags.NonPublic | BindingFlags.Instance);
-                        s_fileStatus_fileCacheField = s_fileSystem_fileStatusField.FieldType.GetField("_fileCache", BindingFlags.NonPublic | BindingFlags.Instance);
-                        s_fileStatusModeField = s_fileStatus_fileCacheField.FieldType.GetField("Mode", BindingFlags.NonPublic | BindingFlags.Instance);
-                    }
-                    catch (Exception ex)
-                    {
-                        throw new Exception("Cannot setup _fileStatus via private reflection from libraries. Verify if the FileSystem._fileStatus._fileCache.Mode chain is intact, otherwise adjust this implementation", ex);
-                    }
-                }
-            }
-
-            public static int GetFileMode(string path)
-            {
-                try
-                {
-                    var fileInfo = new FileInfo(path);
-                    _ = fileInfo.IsReadOnly; // this is to implicitly initialize FileInfo -> FileSystem -> fileCache instance
-
-                    return (int)s_fileStatusModeField.GetValue(
-                               s_fileStatus_fileCacheField.GetValue(
-                                   s_fileSystem_fileStatusField.GetValue(fileInfo)));
-                }
-                catch (Exception ex)
-                {
-                    throw new Exception("Cannot get stat (2) st_mode via private reflection from libraries. Verify if the FileSystem._fileStatus.Initialize logic is exercised via FileInfo.IsReadOnly in FileStatus.Unix.cs, otherwise adjust this implementation.", ex);
-                }
-            }
-        }
-
         private class TestDirectory : IDisposable
         {
             public string Path { get; private set; }