Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mscorlib references under src\coreclr\src #39994

Merged
merged 8 commits into from
Jul 28, 2020
Merged

Cleanup mscorlib references under src\coreclr\src #39994

merged 8 commits into from
Jul 28, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jul 28, 2020

Fixes #39986

@jkotas jkotas requested a review from danmoseley July 28, 2020 07:12
danmoseley
danmoseley approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@jkotas jkotas mentioned this pull request Jul 28, 2020
Closed
@jkotas
Copy link
Member Author

jkotas commented Jul 28, 2020

CI failures are:

@jkotas jkotas merged commit 04fbbd9 into dotnet:master Jul 28, 2020
@jkotas jkotas deleted the mscorlib branch July 28, 2020 23:10
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@jkotas @Jacksondr5
Cleanup mscorlib references under src\coreclr\src (dotnet#39994)
a7a55c6 
* s/MscorlibBinder/CoreLibBinder/

* s/g_Mscorlib/g_CoreLib/

* Remaining mscorlib->corelib renames

* Delete unreachable FNV NGen string
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

mscorlib.dll is outdated in the comment.
5 participants
@jkotas @am11 @danmoseley @karelz @Dotnet-GitSync-Bot